Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set random cosmetic traits when beginning creation of custom character #60959

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Set random cosmetic traits when beginning creation of custom character #60959

merged 2 commits into from
Sep 14, 2022

Conversation

Night-Pryanik
Copy link
Contributor

Summary

Interface "Set random cosmetic traits when beginning creation of custom character"

Purpose of change

Contribute to #60049. This PR doesn't close that issue because cosmetic traits can still be deselected.

Describe the solution

Extracted randomizing cosmetic traits into a new function and applied it when beginning creation of custom character.

Describe alternatives you've considered

None.

Testing

Started creating Custom character several times and checked that cosmetic traits are applied and randomized.

Additional context

None.

@Night-Pryanik Night-Pryanik added [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world labels Sep 13, 2022
@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions labels Sep 13, 2022
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 13, 2022
@dseguin dseguin merged commit 0262cf2 into CleverRaven:master Sep 14, 2022
@Night-Pryanik Night-Pryanik deleted the cosmetics branch September 14, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants