Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call rebuild_vehicle_level_caches in grabbed_veh_move #60911

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented Sep 11, 2022

Summary

None

Purpose of change

Fixes #53330
Fixes #53555
Fixes #59731
Fixes #58469 (likely, couldn't replicate on latest master according to instructions but symptoms match)

Describe the solution

Call map::rebuild_vehicle_level_caches in game::grabbed_veh_move

Draisines still have weird collisions with train tracks but no longer duplicate parts while grabbed

Couldn't replicate behavior with camp board messing with grab but symptoms are exactly same as in other issues

Describe alternatives you've considered

Testing

  1. Load Racks Serialization Test.zip
  2. G, left arrow, right arrow -> phantom part should remain
  3. Alternatively follow instructions in comment at Vehicular childbirth #53330 (comment) (doesn't always reproduce - on 3rd attempt for me, try spawning scooter in different locations on submap).
  4. Apply patch, repeat steps 1-3 should be no phantom parts

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) labels Sep 11, 2022
@irwiss irwiss marked this pull request as ready for review September 11, 2022 01:31
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 11, 2022
@dseguin dseguin merged commit 17a0b22 into CleverRaven:master Sep 12, 2022
@NetSysFire NetSysFire added the Vehicles Vehicles, parts, mechanics & interactions label Sep 12, 2022
@irwiss irwiss deleted the shoo-phantom-parts branch September 12, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
3 participants