Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingot separation #60839

Merged
merged 11 commits into from
Sep 8, 2022
Merged

Ingot separation #60839

merged 11 commits into from
Sep 8, 2022

Conversation

Drew4484
Copy link
Contributor

@Drew4484 Drew4484 commented Sep 7, 2022

Summary

Content "Recipes to dismantle ingots"

Purpose of change

Allows disassembly of 5L, 10L, and the Exodii's gigantic ingots.

Describe the solution

This was being worked on by someone else (who is no longer part of the project) so I didn't add them when I created the steel ingots. This picks up where they left off.

Describe alternatives you've considered

None

Testing

WIP

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 7, 2022
@anoobindisguise
Copy link
Contributor

I was considering giving these "charges" and then using a recipe to craft a chunk of their respective materials with metal sawing and using 1 charge of their "ammo". It would require making the individual ingots weigh nothing and giving them a fake ammo type with no unload, and making them no reload, then weighting the ammo appropriately, but it would probably allow for more gradual disassembly of the ingots. Only issue I can think of is that it will give you "this X is too large and bulky to disassemble properly" so it could instead be activated with a metal sawing activity.

@github-actions github-actions bot added the Code: Tests Measurement, self-control, statistics, balancing. label Sep 8, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 8, 2022
@Drew4484 Drew4484 marked this pull request as ready for review September 8, 2022 03:11
@Drew4484
Copy link
Contributor Author

Drew4484 commented Sep 8, 2022

I was considering giving these "charges" and then using a recipe to craft a chunk of their respective materials with metal sawing and using 1 charge of their "ammo". It would require making the individual ingots weigh nothing and giving them a fake ammo type with no unload, and making them no reload, then weighting the ammo appropriately, but it would probably allow for more gradual disassembly of the ingots. Only issue I can think of is that it will give you "this X is too large and bulky to disassemble properly" so it could instead be activated with a metal sawing activity.

Not a bad idea but I think charges are on their way out, right?

@dseguin dseguin merged commit 435565c into CleverRaven:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants