Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carpet more floors #60622

Merged
merged 18 commits into from
Sep 19, 2022
Merged

Carpet more floors #60622

merged 18 commits into from
Sep 19, 2022

Conversation

gettingusedto
Copy link
Contributor

Summary

Bugfixes "Add more floors for placing carpets"

Purpose of change

Fixes #58245

Describe the solution

Add more variants for the "place carpet" construction options.

Describe alternatives you've considered

Not doing it.

Testing

I make it as a mod and it looks like it works. Might need to test more.

Additional context

This is my first pull request, feedback and a help would be appreciated.

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling astyled astyled PR, label is assigned by github actions labels Aug 31, 2022
@sadenar
Copy link
Contributor

sadenar commented Aug 31, 2022

This might be nitpicking, but I doubt the realism of the carpet adding to concrete floors using nails, maybe have a requirement of it needing glue or adhesive tape?

@gettingusedto
Copy link
Contributor Author

This might be nitpicking, but I doubt the realism of the carpet adding to concrete floors using nails, maybe have a requirement of it needing glue or adhesive tape?

I can do that. Could a tube of superglue glue a carpet down?

@Zireael07
Copy link
Contributor

I don't think superglue is used (too much risk of tearing, damaging the carpet). Adhesive tape, on the other hand...

@gettingusedto
Copy link
Contributor Author

Do we even have double sided tape item ingame, or do duct tape covers that?

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Sep 1, 2022
@gettingusedto
Copy link
Contributor Author

looks like thats the most of it. let me know if i miss something or something needs changing.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 1, 2022
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 3, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 5, 2022
Copy link
Contributor

@Fris0uman Fris0uman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hookup the new carpets to old carpets using looks_like

@Fris0uman Fris0uman merged commit fa2837c into CleverRaven:master Sep 19, 2022
@gettingusedto gettingusedto deleted the carpetfix branch September 19, 2022 11:19
@gettingusedto gettingusedto mentioned this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't place carpet on any floor except t_floor
4 participants