Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab-quality filter paper and gasket changes #60616

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

onura46
Copy link
Contributor

@onura46 onura46 commented Aug 31, 2022

Summary

None

Purpose of change

Removes qualitative/quantitative filter paper recipes; changes item groups for filter paper and gaskets

Describe the solution

This PR is part 3 - and the last for the moment - of splitting apart #59386 for easier merging.

It removes the ability to craft lab-quality qualitative/quantitative filter paper because, in reality, this would be impossible for a survivor to craft, especially with the recipe given. It also moves filter paper to the 'tools_science' groups, which gives it the ability to spawn in more civilian environments like nursing homes and sewage treatment plants. Since this is a PR related to cannabis extract changes, I also added "gasket_plastic" - which are used extensively in these recipes - to the 'supplies_hardware' item group for more civilian spawn opportunities.

Describe alternatives you've considered

Testing

Tested on my own compiled version.

Additional context

Descriptions of filter paper and a little description of how and what they're made of, which I think makes it obvious why a survivor couldn't craft them.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Spawn Creatures, items, vehicles, locations appearing on map astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 31, 2022
@dseguin dseguin merged commit 5870131 into CleverRaven:master Sep 1, 2022
@onura46 onura46 deleted the cannabis-extract-fixes-3 branch September 11, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants