-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow crossbows to be used in practice recipes #60560
Merged
Fris0uman
merged 7 commits into
CleverRaven:master
from
MNG-cataclysm:crossbow_training
Aug 30, 2022
Merged
Allow crossbows to be used in practice recipes #60560
Fris0uman
merged 7 commits into
CleverRaven:master
from
MNG-cataclysm:crossbow_training
Aug 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
astyled
astyled PR, label is assigned by github actions
labels
Aug 29, 2022
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Aug 29, 2022
github-actions
bot
added
Code: Tooling
Tooling that is not part of the main game but is part of the repo.
<Bugfix>
This is a fix for a bug (or closes open issue)
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Aug 29, 2022
Maleclypse
approved these changes
Aug 30, 2022
Fris0uman
reviewed
Aug 30, 2022
github-actions
bot
removed
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Aug 30, 2022
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
<Bugfix>
This is a fix for a bug (or closes open issue)
Code: Tooling
Tooling that is not part of the main game but is part of the repo.
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Allow for crossbows to be used in practice recipes."
Purpose of change
Allow for crossbows to be used in practice recipes to train gun skills.
Describe the solution
Added two new practice recipes for crossbows. They work like archery practice, requiring the use of bolts in order to train the rifle skill.
Describe alternatives you've considered
Giving crossbows a rifle quality to be used in the targeting game, like other guns.
Testing
None
Additional context
Closes #60498