Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow crossbows to be used in practice recipes #60560

Merged
merged 7 commits into from
Aug 30, 2022

Conversation

MNG-cataclysm
Copy link
Contributor

@MNG-cataclysm MNG-cataclysm commented Aug 29, 2022

Summary

Content "Allow for crossbows to be used in practice recipes."

Purpose of change

Allow for crossbows to be used in practice recipes to train gun skills.

Describe the solution

Added two new practice recipes for crossbows. They work like archery practice, requiring the use of bolts in order to train the rifle skill.

Describe alternatives you've considered

Giving crossbows a rifle quality to be used in the targeting game, like other guns.

Testing

None

Additional context

Closes #60498

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling astyled astyled PR, label is assigned by github actions labels Aug 29, 2022
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Practice firing unfletched bolts at a spot on the wall.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Aug 29, 2022
@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. <Bugfix> This is a fix for a bug (or closes open issue) BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 29, 2022
data/json/recipes/practice/ranged.json Outdated Show resolved Hide resolved
data/json/recipes/practice/ranged.json Outdated Show resolved Hide resolved
@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 30, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 30, 2022
@Fris0uman Fris0uman merged commit 9bd27c3 into CleverRaven:master Aug 30, 2022
@MNG-cataclysm MNG-cataclysm deleted the crossbow_training branch August 30, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Code: Tooling Tooling that is not part of the main game but is part of the repo. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crossbow training with archery targets.
3 participants