Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Some typo and terminal punctuation fixes, the
<fuck_you>
category of snippets is only used in contexts where terminal punctuation is already added (e.gblah, <fuck_you>!
). It caught my eye when I was looking through the file due to its inconsistent use of terminal punctuation.Describe the solution
Added some very shallow lore into the snippet category. Also replaced some usages of zombies and apocalypse to their snippet categories for variety.
Describe alternatives you've considered
npc_socialize
to<npc_socialize>
and madenpc_socialize
contain<npc_socialize>
. This is because I did not want to touch C++ and is a hack, more or less.Cataclysm-DDA/src/npctalk_funcs.cpp
Lines 767 to 769 in 6791af5
But I realized this is a very ugly hack. Even though it works and adds even more flavor to the neutral chitchat, I do not think we need it and reverted it.
Testing
Applied changes locally, gave myself the debug mind control trait, forced NPCs to have chitchat with me. This is also how I found the need to use a hack and made up my mind that I do not want to use it.
Additional context
When I used the hack, but this still demonstrates that the other snippet category I added works properly: