Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more npc quips and fixes #60553

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Conversation

NetSysFire
Copy link
Member

Summary

None

Purpose of change

Some typo and terminal punctuation fixes, the <fuck_you> category of snippets is only used in contexts where terminal punctuation is already added (e.g blah, <fuck_you>!). It caught my eye when I was looking through the file due to its inconsistent use of terminal punctuation.

Describe the solution

Added some very shallow lore into the snippet category. Also replaced some usages of zombies and apocalypse to their snippet categories for variety.

Describe alternatives you've considered

  1. Replacing "Mr. Cuddles" with a list of possible pet names, but this would mean that if you get lucky with the RNG or are incredibly persistent, a NPC would claim they had multiple and possibly a lot of cats, ranging from "Mr. Cuddles" to "Fluffy". This is relatively minor yet it still bugs me.
  2. Adding more puns and potentially an own category for it. I am very good at coming up with bad puns but I feel like they will make humanity suffer more than the debilitating mental effects of the blob.
  3. I renamed npc_socialize to <npc_socialize> and made npc_socialize contain <npc_socialize>. This is because I did not want to touch C++ and is a hack, more or less.

if( one_in( 3 ) ) {
p.say( SNIPPET.random_from_category( "npc_socialize" ).value_or( translation() ).translated() );
}

But I realized this is a very ugly hack. Even though it works and adds even more flavor to the neutral chitchat, I do not think we need it and reverted it.

Testing

Applied changes locally, gave myself the debug mind control trait, forced NPCs to have chitchat with me. This is also how I found the need to use a hack and made up my mind that I do not want to use it.

Additional context

When I used the hack, but this still demonstrates that the other snippet category I added works properly:

image

@NetSysFire NetSysFire added NPC / Factions NPCs, AI, Speech, Factions, Ownership Lore Game lore, in-game communication. Also the Lore tab. labels Aug 29, 2022
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 29, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 29, 2022
@Fris0uman Fris0uman merged commit a53bc15 into CleverRaven:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Lore Game lore, in-game communication. Also the Lore tab. NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants