fix: PR template comments triggers bugfix label #60529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure the comments in the template don't result in a match for the bugfix label everything is not a bugfix
github-actions
bot
added
Code: Tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
#60287 makes pretty much all prs to be labeled as bugfixes, turns out the comments in the pr template match the regex needed to trigger the labeling
make sure the comments in the template don't result in a match for
the bugfix label
everything is not a bugfix
Describe the solution
Describe alternatives you've considered
Testing
go to the website where I tested the regex https://regex101.com/r/pBIUNe/1 and input the modified pr template, no matches
this pr also should not get the bugfix label
Additional context
dirty hack, change numbers to a place holder
xxxx