Update hypotetical passive solar panel bionic to use irradiance #60445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Hirmuolio
added a commit
to Hirmuolio/Cataclysm-DDA
that referenced
this pull request
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Update hypotetical passive solar panel bionic to use irradiance"
Purpose of change
In #59179 I missed this part of the code.
I believe it to be used for solar panel bionics that are passive (can't be turned on/off).
No such thing exists. The aftershock solar panel bionic can be turned on/off and does not use this part of the code. But if someone makes such creation it will now match the behavior of toggleable solar panel bionic.
Describe the solution
Compare solar irradiance instead of light level.
Describe alternatives you've considered
Remove support for hypotetical bionic that does not exist.
Testing
It is not used anywhere so it is untested. But the code is basically identical to activateable solar bionics so it should work.
Additional context
I have a feeling that
Character::burn_fuelandCharacter::passive_power_gencould be somehow combined into one thing.