Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lower price of ASRG #60424

Merged
merged 2 commits into from
Aug 26, 2022
Merged

lower price of ASRG #60424

merged 2 commits into from
Aug 26, 2022

Conversation

anoobindisguise
Copy link
Contributor

@anoobindisguise anoobindisguise commented Aug 24, 2022 •
edited
Loading

Summary

Balance "ASRG price was too high"

Purpose of change

Per POSTAPOC_PRICE_GUIDE no item should be worth more than 15000 cents. An advanced solar panel was worth 3000 cents. price of ASRG was too high.

Describe the solution

Lower price to 12000, as 4x is a good ballpark estimate for its power output compared to an adv. solar panel.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Appliance/Power Grid Anything to do with appliances and power grid json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 24, 2022
Rivet-the-Zombie
Rivet-the-Zombie requested changes Aug 25, 2022
View reviewed changes
Copy link
Member

@Rivet-the-Zombie Rivet-the-Zombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, but the item's name is misspelled - should be 'Stirling' instead of 'Sterling'.

@github-actions github-actions bot added the Game: Balance Balancing of (existing) in-game features. label Aug 25, 2022
@bombasticSlacks bombasticSlacks merged commit d0f4854 into CleverRaven:master Aug 26, 2022
Hirmuolio pushed a commit to Hirmuolio/Cataclysm-DDA that referenced this pull request Aug 27, 2022
@anoobindisguise @Hirmuolio
lower price of ASRG (CleverRaven#60424)
66e0855 
* lower price of ASRG

* fix a typo
@anoobindisguise anoobindisguise deleted the anoobindisguise-lower_asrg_price-1 branch October 14, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rivet-the-Zombie Rivet-the-Zombie Rivet-the-Zombie requested changes

@Maleclypse Maleclypse Maleclypse approved these changes

Assignees
No one assigned
Labels
Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anoobindisguise @Rivet-the-Zombie @Maleclypse @bombasticSlacks