Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HEAL #60289

Merged
merged 1 commit into from
Aug 20, 2022
Merged

Fix HEAL #60289

merged 1 commit into from
Aug 20, 2022

Conversation

KymasTuran
Copy link
Contributor

@KymasTuran KymasTuran commented Aug 19, 2022

Fix HEAL spell in artifact.

Summary

Bugfixes "Heal spell cast by artifacts dont work. This should fix that"

Purpose of change

Fix #60288. If you use an heal artifact it cause damage instead of heal, it can even damage your armor.

Describe the solution

Change to negative numbers. Negative damage heal.

Describe alternatives you've considered

Do nothing.

Testing

Spawn am Heal artifact, activate, it heal a bit of the character.

Additional context

None

Fix HEAL spell in artifact.
@github-actions github-actions bot added the [JSON] Changes (can be) made in JSON label Aug 19, 2022
Copy link
Contributor Author

@KymasTuran KymasTuran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though I need to report the bug #60288 (comment) and after that upload the solution. New guy :p

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 19, 2022
@PatrikLundell
Copy link
Contributor

A few tips for a new guy...

The Summary entry has to follow the rigid format described in the comment, because it's parsed by a script.
Thus, "Category" has to be replaced by one of the listed keywords, and the "Brief description" text replaced by a brief description of what the change is about. Alternatively, use the keyword None and no description string.

I believe this is a fix for a bug report. If that's the case, the Purpose of change section should state
Fix #
as well as a brief indication what the bug is about (in this case healing artifacts not working) so people can understand what the PR is about without having to refer to the bug report.

Also, the Testing section should contain an indication that you've actually tested that it gives the correct result.
Thus, you should get hold of such an artifact (I guess artifacts can be debug spawned) and verify that it does actually heal an injured character.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 19, 2022
@KymasTuran
Copy link
Contributor Author

Thank you [PatrikLundell] . Its extra difficult for non english speaker but I think I succed.

@Rivet-the-Zombie Rivet-the-Zombie merged commit 630e438 into CleverRaven:master Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifact dont heal
3 participants