Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added myself to comment-commands.yml #60274

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Added myself to comment-commands.yml #60274

merged 1 commit into from
Sep 4, 2022

Conversation

sonphantrung
Copy link
Contributor

@sonphantrung sonphantrung commented Aug 18, 2022 •
edited
Loading

Summary

None

Purpose of change

I'm willing to test savefiles to see if something's broken ;)

Describe the solution

Added myself

Describe alternatives you've considered

Not doing this

Testing

Hmm, very obvious

Additional context

I'll be removed from the file if I'm a dick, right?

@sonphantrung sonphantrung changed the title Comment commands Added myself to comment-commands.yml Aug 18, 2022
@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 18, 2022
@Zireael07
Copy link
Contributor

Why close?

@sonphantrung
Copy link
Contributor Author

Haha, it's just basically me not noticing that there were some merge conflicts which would delete all of my commits. Reopening now

@sonphantrung sonphantrung reopened this Aug 30, 2022
@dseguin dseguin merged commit c579a56 into CleverRaven:master Sep 4, 2022
@sonphantrung sonphantrung deleted the comment-commands branch September 4, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maleclypse Maleclypse Maleclypse approved these changes

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sonphantrung @Zireael07 @Maleclypse @dseguin