Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 1-tile spell AoE #60172

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Allow 1-tile spell AoE #60172

merged 1 commit into from
Aug 15, 2022

Conversation

Venera3
Copy link
Member

@Venera3 Venera3 commented Aug 15, 2022

Summary

None

Purpose of change

Allow spells to define one-tile AoEs (currently e.g. a blast is either 1x1 only affecting the target tile or ~5x5).

Describe the solution

AoEs below 1 will default to only painting the target tile.

Describe alternatives you've considered

None

Testing

Preceding the changes defined a blast spell with an AoE of 1, only the target tile is affected. Redefined the AoE as 2, a 5x5 circle is hit.
After the changes an AoE of 1 hits a 3x3 area, other sizes are not affected.

Additional context

@Venera3 Venera3 requested a review from KorGgenT as a code owner August 15, 2022 11:34
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 15, 2022
@NetSysFire NetSysFire added the Mechanics: Enchantments / Spells Enchantments and spells label Aug 15, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 15, 2022
@dseguin dseguin merged commit f43175e into CleverRaven:master Aug 15, 2022
@Venera3 Venera3 deleted the spell_aoe branch September 11, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants