Reducing the Wil Wheaton factor of the rng-test #60154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Stadler76
changed the title
github-actions
bot
added
json-styled
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Reducing the Wil Wheaton factor of the rng-test"
Purpose of change
Reduce the chance of CI runs failing due to bad rng in an rng-test.
Describe the solution
In one of my PRs I've encountered a reproducable test failure due to bad rng. Raising the number of samples from 100 to 200 fixed it.
Additionally I've tagged the 3 tests there with
[rng].Describe alternatives you've considered
Blame Wil Wheaton™ for it and don't change the test?!
Testing
After raising the number of samples from 100 to 200 I couldn't repro it anymore with the same seed.
Additional context
For those who're asking why the fuzz about Wil Wheaton, then here's the proof: The Wil Wheaton Dice Curse - YouTube
I have to warn you to not watch the video with headphones on and it's recommended to reduce the volume because of the loud laughs of the audience (and Wil Wheaton).