Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mouse support to mission menu (M) #60084

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

leemuar
Copy link
Contributor

@leemuar leemuar commented Aug 11, 2022

Summary

Features "Mission menu window (M) now has mouse support: you can click on tabs, hover over mission names and click on mission names to make it active"

Purpose of change

fixes #60083
expand mouse support to yet another UI window

Describe the solution

Describe alternatives you've considered

Testing

Generate lots of missions
Open mission menu
Make sure you can switch tabs by clicking on tab name
Make sure hovering on mission name row show you mission description
Make sure clicking on mission name on active mission tab makes this mission active
Make sure mouse scroll scroll missions up and down

Additional context

Im not quite happy with the result, it could use some optimization. But it will do as MVP

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. Missions Quests and missions <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 11, 2022
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 12, 2022
@dseguin dseguin merged commit 070b731 into CleverRaven:master Aug 18, 2022
Hirmuolio pushed a commit to Hirmuolio/Cataclysm-DDA that referenced this pull request Aug 27, 2022
* add mouse support to mussuin menu

* fix astyle

Co-authored-by: Тимур Кашафутдинов <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions Missions Quests and missions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mouse support to a mission menu (M)
2 participants