Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One more fix for qt_machete recipe #60059

Conversation

anoobindisguise
Copy link
Contributor

@anoobindisguise anoobindisguise commented Aug 10, 2022

Summary

Bugfixes "qt machete doesn't need carbon"

Purpose of change

I misunderstood the process, you are merely quenching and then tempering the already completed blade.

Describe the solution

No extra carbon is needed. Removed the extra bladesmithing/blacksmithing profs since you aren't forging it proper, just tempering it. I also modified the grip recipe per Drew's advice, it requires some more complicated materials to form a proper weapon grip now.

Describe alternatives you've considered

let @Drew4484 do it

Testing

Additional context

qt machete

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions labels Aug 10, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 10, 2022
@anoobindisguise anoobindisguise marked this pull request as draft August 11, 2022 00:01
@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 11, 2022
anoobindisguise and others added 2 commits August 10, 2022 17:06
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 11, 2022
@anoobindisguise anoobindisguise marked this pull request as ready for review August 12, 2022 01:28
@Rivet-the-Zombie Rivet-the-Zombie merged commit 0df7d8f into CleverRaven:master Aug 14, 2022
@anoobindisguise anoobindisguise deleted the anoobindisguise-qt_machete_recipe branch October 14, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants