Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RUBIK_ANUS_FETICK mission refer to units, not liters #60037

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

DeeUnderscore
Copy link
Contributor

Summary

None

Purpose of change

Currently, the mission where Rubik asks you to fetch some anesthetic asks for 1 liter of anesthetic. However, 1 liter of anesthetic is something like 778 charges, while the actual requirement is 1000 charges.

Describe the solution

Change dialog and mission description to have Rubik ask for 1000 units of anus feticks instead.

Describe alternatives you've considered

I think "units" is a sufficiently medical-sounding term to use here. Rubik could perhaps have some more colorful description, but I think this one is good enough.

Testing

Loaded the modified JSON in game and ran through the conversation.

Additional context

N/A

1 liter of anesthetic is about 778 charges, but the mission actually
requires 1000 charges.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Missions Quests and missions Mods Issues related to mods or modding NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Aug 8, 2022
@ANickelN
Copy link
Contributor

ANickelN commented Aug 8, 2022

Why not change the actual requirement to 778 charges (1 Liter) instead of doing it the other way around?

It seems changing the text to match the requirement makes less sense than fixing the requirement so it fits the text?

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 8, 2022
@DeeUnderscore
Copy link
Contributor Author

The volume of a liquid you're carrying is more tricky to figure out than the amount of charges, since you need to descend into menus/descriptions to see it. It's also possible to set your game to display volume in units other than liters. I think things are generally clearer if the game asks for a number of charges and doesn't ask the player to do math.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 9, 2022
@Maleclypse
Copy link
Member

If 776 charges is one liter then 100 charges is roughly equal to a gill. https://en.wikipedia.org/wiki/Gill_(unit)

@BrettDong BrettDong added the Info / User Interface Game - player communication, menus, etc. label Aug 9, 2022
@AtomicFox556
Copy link
Contributor

AtomicFox556 commented Aug 9, 2022

Seems like a good opportunity to demonstrate the complications of coming from different worlds: the measurement units won't ever completely match up, so I would expect medical knowledge of the player character to help figuring out how much is actually needed in terms of in-game units for the mentioned purpose, otherwise Rubik could just say that they want more if you bring too little.

@pjf
Copy link
Contributor

pjf commented Aug 9, 2022

Seems like a good opportunity to demonstrate the complications of coming from different worlds: the measurement units won't ever completely match up.

This is especially the case if there are different timelines involved. From Wikipedia:

The original French metric system used the litre as a base unit. The word litre is derived from an older French unit, the litron, whose name came from Byzantine Greek—where it was a unit of weight, not volume—via Late Medieval Latin, and which equalled approximately 0.831 litres.

However if the Exodii can provide blueprints the player can make sense of, then I'm ken they can provide a precise volume/quantity when giving a quest, even if that's just by supplying/pointing to a container of the appropriate size.

@PatrikLundell
Copy link
Contributor

Whether the PC may or may not know how many of one units there are in another unit is not particularly relevant, as the PC doesn't have any ability to communicate with the player. Checks in dialogs can transfer some info, but only if that dialog has actually been written.
Also, the game's normal units are either 250ml or 1 ml for fluids. There's no indication to the player that this particular fluid uses some unit other than one of these, so you'd only find out if you fiddle around with the UI AND pay close attention to things you have no reason to pay special attention to.

@DeeUnderscore
Copy link
Contributor Author

Yes, the main issue right now is that the conversation option for "here's the anesthetic" only becomes available if you have 1000 charges of it in your inventory. If the player brings less than that, there is no indication that it's not enough, no matter how many conversation trees they go through looking for that. If confusion about the amounts is to be relevant to the plot then ideally it should be clear that it is an in-universe thing, and not some bug that stops the mission from going through.

And yes, we could have dialog in which determining the actual amount goes on, depending on the player's character skills, but there's also the mission description, and ideally that'd reflect whatever conclusion was reached through the conversation tree. I don't know if mission descriptions can be conditional like that, so we'd need multiple missions... But then we'd also need to handle what happens when the player character actually increases their skills in the meantime, and theoretically should now be able to figure out the exact amount.

That isn't to say that it's impossible to have a more complex handling of this situation, but it that would be more complex.

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Sep 21, 2022
Copy link
Member

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m going to side with clarity of mission over thematic value since there is significant content potentially gated by this mission.

@stale stale bot removed the stale Closed for lack of activity, but still valid. label Sep 21, 2022
@dseguin dseguin merged commit 3309c21 into CleverRaven:master Sep 21, 2022
@DeeUnderscore DeeUnderscore deleted the rubik-units branch September 21, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions Mods Issues related to mods or modding NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants