Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DinoMod] fix dino loot #59812

Merged
merged 25 commits into from
Aug 1, 2022
Merged

[DinoMod] fix dino loot #59812

merged 25 commits into from
Aug 1, 2022

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Aug 1, 2022

Summary

Bugfixes "[DinoMod] fix dino loot"

Purpose of change

Bugfix loot broken by #59075

Describe the solution

Replaces all instances of "spider" item group in DinoMod and Innawood with either science or military item groups. Removes spider item group entry from Innawood and adds military entry.

Describe alternatives you've considered

Just copy over the old spider item group into DinoMod, but I'd rather use currently maintained item groups for consistency with main game

Testing

Simple JSON subs

Additional context

N/A

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods Issues related to mods or modding Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: Innawood 🌲 Anything to do with Innawood mod labels Aug 1, 2022
@github-actions github-actions bot added the Spawn Creatures, items, vehicles, locations appearing on map label Aug 1, 2022
@LyleSY LyleSY added the <Bugfix> This is a fix for a bug (or closes open issue) label Aug 1, 2022
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Aug 1, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 1, 2022
@LyleSY LyleSY marked this pull request as ready for review August 1, 2022 15:08
@dseguin dseguin merged commit c4a8f3c into CleverRaven:master Aug 1, 2022
@LyleSY LyleSY deleted the fix_dino_loot branch August 1, 2022 23:07
alef pushed a commit to alef/Cataclysm-DDA that referenced this pull request Aug 6, 2022
* [DinoMod] loot fixes

* Update nest_acrocanthosaurus.json

* Update nest_albertosaurus.json

* Update nest_allosaurus.json

* Update nest_appalachiosaurus.json

* Update nest_ceratosaurus.json

* Update nest_coelophysis.json

* Update nest_daspletosaurus.json

* Update nest_deinonychus.json

* Update nest_dilophosaurus.json

* Update nest_dromaeosaurus.json

* Update nest_dromaeosaurus.json

* Update nest_dryptosaurus.json

* Update nest_gorgosaurus.json

* Update nest_nanuqsaurus.json

* Update nest_saurornitholestes.json

* Update nest_siats.json

* Update nest_stenonychosaurus.json

* Update nest_torvosaurus.json

* Update nest_tyrannosaurus.json

* Update nest_utahraptor.json

* Update nest_velociraptor.json

* Create military.json

* Update monster_drops_lairs.json

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: Innawood 🌲 Anything to do with Innawood mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants