-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DinoMod] fix dino loot #59812
Merged
Merged
[DinoMod] fix dino loot #59812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Mods
Issues related to mods or modding
Mods: Dinomod
Anything to do with the Dinoclysm mod (DinoMod)
Mods: Innawood 🌲
Anything to do with Innawood mod
labels
Aug 1, 2022
github-actions
bot
added
the
Spawn
Creatures, items, vehicles, locations appearing on map
label
Aug 1, 2022
github-actions
bot
added
the
astyled
astyled PR, label is assigned by github actions
label
Aug 1, 2022
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Aug 1, 2022
alef
pushed a commit
to alef/Cataclysm-DDA
that referenced
this pull request
Aug 6, 2022
* [DinoMod] loot fixes * Update nest_acrocanthosaurus.json * Update nest_albertosaurus.json * Update nest_allosaurus.json * Update nest_appalachiosaurus.json * Update nest_ceratosaurus.json * Update nest_coelophysis.json * Update nest_daspletosaurus.json * Update nest_deinonychus.json * Update nest_dilophosaurus.json * Update nest_dromaeosaurus.json * Update nest_dromaeosaurus.json * Update nest_dryptosaurus.json * Update nest_gorgosaurus.json * Update nest_nanuqsaurus.json * Update nest_saurornitholestes.json * Update nest_siats.json * Update nest_stenonychosaurus.json * Update nest_torvosaurus.json * Update nest_tyrannosaurus.json * Update nest_utahraptor.json * Update nest_velociraptor.json * Create military.json * Update monster_drops_lairs.json * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
<Bugfix>
This is a fix for a bug (or closes open issue)
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Mods: Dinomod
Anything to do with the Dinoclysm mod (DinoMod)
Mods: Innawood 🌲
Anything to do with Innawood mod
Mods
Issues related to mods or modding
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "[DinoMod] fix dino loot"
Purpose of change
Bugfix loot broken by #59075
Describe the solution
Replaces all instances of "spider" item group in DinoMod and Innawood with either science or military item groups. Removes spider item group entry from Innawood and adds military entry.
Describe alternatives you've considered
Just copy over the old spider item group into DinoMod, but I'd rather use currently maintained item groups for consistency with main game
Testing
Simple JSON subs
Additional context
N/A