Innawoods updating 2 #59772
Merged
Innawoods updating 2 #59772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibercloth patches, desc update
fibercloth update
fix honeydew recipe quantity.
updated makeshift bandages
update yoke and duct tape with more coherent patch requirements.
fibercloth uncraft
updating for fibercloth patches
updating for fibercloth patches
canvas bags with fibercloth.
|
@Light-Wave for review |
github-actions
bot
added
Mods
|
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
github-actions
bot
added
the
json-styled
add fibercloth
github-actions
bot
added
Code: Tooling
Light-Wave
approved these changes
Jul 31, 2022
alef
pushed a commit
to alef/Cataclysm-DDA
that referenced
this pull request
Aug 6, 2022
* Update tool_tailoring.json fibercloth patches, desc update * Update materials.json fibercloth update * Update recipe_food.json fix honeydew recipe quantity. * Update medsandchemicals.json updated makeshift bandages * Update recipe_others.json update yoke and duct tape with more coherent patch requirements. * Update recipe_deconstruction.json fibercloth uncraft * Update tailoring.json updating for fibercloth patches * Update materials.json updating for fibercloth patches * Update tools_containers.json canvas bags with fibercloth. * Update dictionary.txt add fibercloth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "Fibercloth updates and honeydew fix"
Purpose of change
Updating fibercloth to be more in-line with fabric in mainline by adding patches and uses for them. Also adds a recipe for making makeshift bandages directly from sheets for QoL purposes. Its no different to cutting up a sheet and making bandages from the patches time-wise, but still nice to have.
Also fixed up fresh honeydew > honeydew (it should not have been that efficient). Updates yokes and duct tape as well due to it being more efficient to make it out of patches instead of sheet equivalent.
Canvas sacks and bags are one of the few items that specifically need only cotton patches, so updated them for fibercloth.
Describe the solution
Adds fibercloth patches, all related requirements updated. Makeshift Bandage recipes added. Fix up charges for honeydew recipe. Update yoke and duct tape recipe requirements. Update canvas bag + sack recipe requirements.
Describe alternatives you've considered
Having fibercloth sheets uncraft into cotton patches and save myself the trouble ><.
Testing
Added all changes and made relevant recipes. No crashes or errors.
Additional context
There's a bunch more recipes that arguably would do having fibercloth patches added to them (generally hilt wrappings and some straps and the like) but unlike the canvas bag/sacks there are alternatives that can be reasonably sourced earlier.
The yoke and duct tape recipes, from what I can figure were based on the old patch-sheet conversion so were set at 6 instead of the current 8.
I could also add patchwork fibercloth sheets, but its not exactly necessary as you only get the patches on purpose and making new sheets is a more reasonable thing to do compared to mainline where the sheets are the less common form of cloth.