Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kitchen units as appliances #59705

Closed
wants to merge 1 commit into from

Conversation

pjf
Copy link
Contributor

@pjf pjf commented Jul 28, 2022

Summary

Content "Kitchen units can now be placed as appliances"

Purpose of change

The RV kitchen unit could be fitted to a vehicle, but not placed as an appliance, despite it making sense to do so.

Describe the solution

JSON edits.

Describe alternatives you've considered

None.

Testing

Placed a kitchen unit in my current game. Have been using it for cooking ever since.

Additional context

This is my first time adding an appliance, so please let me know if I've made any oopsies or not followed any conventions.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Appliance/Power Grid Anything to do with appliances and power grid Crafting / Construction / Recipes Includes: Uncrafting / Disassembling astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 28, 2022
@anothersimulacrum
Copy link
Member

I don't think these should be appliances, they're just worse ovens. We could perhaps have a hotplate appliance, but I don't think this should be an appliance.

@I-am-Erk
Copy link
Member

I agree, I think the solution here is mainly to make a hotplate or electric stovetop appliance, and once we have water running through an appliance grid, a sink would be good too, but separate. Since we don't have water afaik, the kitchen unit doesn't really work as advertised when placed.

@pjf
Copy link
Contributor Author

pjf commented Jul 28, 2022

I'm not at all attached to this PR, my survivor just managed to scavenge a kitchen unit and I wanted to plug it in.

I'm happy to edit the description to note the sink doesn't work, or to just close this and have the kitchen unit appliance on my local branch.

@I-am-Erk
Copy link
Member

I'd suggest closing this PR and making a hotplate appliance, one route to make a hotplate appliance could be to just put some countertop over the sink and use an RV kitchen set.

@pjf
Copy link
Contributor Author

pjf commented Jul 29, 2022

Aye aye! Closing this in favour of a hotplate appliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants