Improve radio scanning experience, make it more likely there will be radios in range #59550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
I've noticed we have this feature from poking around in the code, but every time I've tried to use it, there haven't been any radios in range. This commit does 4 things: 1. Increase both the min and max range of radios, so there's a greater chance a radio will be in range. Numbers semi-arbitrary. 2. Add a debugmode filter for radio, so I can add some debugging messages for it. 3. Save radio frequency, so your radio doesn't lose it's selected frequency every time you reload. 4. Make radio scanning better, and modify how noise is applied to radio messages. While the current scanning is perhaps a little immersive, in actual use it's quite annoying and, because it gives no feedback, it's hard to tell if it actually did anything. Replace this with a list of stations in range that you can select from, with a little descriptor describing how much noise there is (the reason for the modification of the noise). Messages are snippets to enable multiple options and ease of editing.
anothersimulacrum
force-pushed
the
all-i-hear
branch
from
16b67b7 to
fa85211
Compare
BevapDin
reviewed
Jul 30, 2022
| int static_roll = dice( 10, 100 ); | ||
| if( static_roll > signal_roll ) | ||
| const city *c = overmap_buffer.closest_city( tripoint_abs_sm( tref.abs_sm_pos, 0 ) ).city; | ||
| const std::string cityname = c == nullptr ? "ksssh" : c->name; |
There was a problem hiding this comment.
Looks like this is a onomatopoeia, it should probably be translated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Increase range of radios and improve radio scanning experience"
Purpose of change
I've noticed we have this feature from poking around in the code, but every time I've tried to use it, there haven't been any radios in range.
Radios appear largely unchanged since #731
Describe the solution
This commit does 4 things:
While the current scanning is perhaps a little immersive, in actual use it's quite annoying and, because it gives no feedback, it's hard to tell if it actually did anything.
Replace this with a list of stations in range that you can select from, with a little descriptor describing how much noise there is (the reason for the modification of the noise). Messages are snippets to enable multiple options and ease of editing.
Describe alternatives you've considered
Keeping the current scanning, but giving some feedback. Different values for range.
Testing
Spawn in a radio, give it a battery. Activate it and scan for radios. Select a choice, and scan again, see it is still selected. Save and load, then scan again and see the station you previously selected is still selected.
Additional context
The range increase only applies to newly generated radio sources.