-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dost thou even lift: Add makeshift rope and chain lifts #59485
Conversation
Until such time as we can better check the stability of the underlying terrain, the 2x4s can represent mounting a reinforced beam between the roof supports. Adds the option to mount the rope-pulley hoist to a sufficiently sturdy wall (check_support)
This comment was marked as resolved.
This comment was marked as resolved.
This adds everything and is theoretically functional. However, it appears vehicle installation may not be correctly looking at crafting pseudo tools granted by furniture. This is a bug we should probably fix. I have no clue how to fix it. |
Closing 4,5 years old issue, congrats! I think it's gotta be some sort of a record? |
Not a record but it is pretty good. |
#56143 closed 8,5 years issue. |
Normally wouldn't comment on a closed/merged commit like this, but I did have to go looking for this one to figure out how to place the constructions in-game, as it doesn't actually say what terrain/tiles are kosher except for a vague "horizontal beam" or something akin to that? Making the idea of a tree or the 2x4s you mentioned more explicit in-game might help other folks, and prevent bug-reports in the future of "I can't place this construction!" |
Summary
Content "Adds some common makeshift lifting tools"
Purpose of change
Closes #23094
Closes #13562
Describe the solution
Creates three new furnitures and a new 'block and tackle' item. Constructing the furniture is contingent on the terrain present in the tile.
The new block and tackle item is required for making existing rope and pulley systems and included in their deconstruction recipes. While I was in there, I changed the terrain names to fix #13562. The block and tackle also spawns in common hardware groups and garages, and most of the time spawns with a piece of rope or chain attached. I did not add a crafting or uncrafting recipe for it, someone else could look into what that would entail. It could probably be done with sheet metal and small sturdy wheels.
Since I used nuts and bolts here, I made them spawn in more places as they were quite rare (or not spawning at all? Idk) and I've wanted to start requiring specific fasteners a bit more anyway
Describe alternatives you've considered
I am not currently extremely happy with the pre-terrain checks for ceilings. I don't know if you should be able to spike a rope and tackle into a dirt cave ceiling or a crumbling wooden barn and get enough stick. Chain hoists are a bit jank and overly specific. However to improve the pre-terrain check here would either require some new pre-tests for the durability of the underlying terrain, or a new terrain flag representing stronger types of supports. Both of these are things we could use in the future but I really don't wanna do them.
The lift numbers here are somewhat arbitrary. We could consider having more advanced lifting furniture/terrain that has higher lifting numbers.
Testing
Simple rope hoist on a tree
chain hoist in a concrete floor
Lifting quality is granted by the furniture
ed: dang, the game won't acknowledge the nearby lifting furniture for vehicles
Additional context
Just removing two of our oldest issues with an hour or so of work in my breaks. nbd.