Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix closing vehicle doors cardinally #59470

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented Jul 21, 2022

Summary

None

Purpose of change

Fixes #58303

Describe the solution

Check the fake part's is_active_fake before checking collision

While fiddling with it - also caught another bug where opening/closing fake door part didn't
open/close connected doors, the second commit fixes that too.

Describe alternatives you've considered

Testing

Apply patch, align car vertically or horizontally - check closing doors
Align diagonally so door has fake part - check closing doors from inside/outside and on both door tiles - it should work as you expect (not close if the player stands on either real door or fake part), it should close in any position other than that

Additional context

image
Scenario for the second commit fix - blue arrows point to real "trunk doors", orient the car as depicted, then try opening/closing using the tile pointed at by red arrow

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Vehicles Vehicles, parts, mechanics & interactions json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 21, 2022
@NetSysFire NetSysFire added the <Bugfix> This is a fix for a bug (or closes open issue) label Jul 21, 2022
@irwiss irwiss marked this pull request as ready for review July 21, 2022 03:48
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 21, 2022
@dseguin dseguin merged commit 32ee0b1 into CleverRaven:master Jul 25, 2022
@irwiss irwiss deleted the fix-closing-veh-doors-cardinally branch July 25, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant close a non diagonal vehicle door by standing next to it
3 participants