Fix closing vehicle doors cardinally #59470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes #58303
Describe the solution
Check the fake part's
is_active_fake
before checking collisionWhile fiddling with it - also caught another bug where opening/closing fake door part didn't
open/close connected doors, the second commit fixes that too.
Describe alternatives you've considered
Testing
Apply patch, align car vertically or horizontally - check closing doors
Align diagonally so door has fake part - check closing doors from inside/outside and on both door tiles - it should work as you expect (not close if the player stands on either real door or fake part), it should close in any position other than that
Additional context
Scenario for the second commit fix - blue arrows point to real "trunk doors", orient the car as depicted, then try opening/closing using the tile pointed at by red arrow