Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ALL_SEEING monster flag #59398

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Conversation

Venera3
Copy link
Member

@Venera3 Venera3 commented Jul 18, 2022

Summary

None

Purpose of change

Add a way for a monster to see through obstacles.

Describe the solution

Add ALL_SEEING, letting a critter see every other creature on the same Z-level within its (highest) vision range.

Describe alternatives you've considered

Poke a bit more at it and make it work over Z-levels, but 3D stuff makes my head hurt.

Testing

Added the flag to fat zombies, they could see me through walls (checked via Debug Clairvoyance). Moved out of their vision range, they could not see me.

Additional context

@GuardianDll

@Night-Pryanik
Copy link
Contributor

I think we need to add this flag to some monster, otherwise it's a dead code.

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs labels Jul 18, 2022
@GuardianDll
Copy link
Member

Now i have a pretty darn reason to finish my idea

@Venera3
Copy link
Member Author

Venera3 commented Jul 18, 2022

I think we need to add this flag to some monster, otherwise it's a dead code.

GuardianDII asked for a monster they wanted to work on, but if it's necessary it could make a good fit for the Tindalos puppies for that extra paranoia factor.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 18, 2022
@Venera3
Copy link
Member Author

Venera3 commented Jul 19, 2022

Went ahead and added it to the relentless hulk - they're challenge-only and could use the help.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. labels Jul 19, 2022
@GuardianDll GuardianDll mentioned this pull request Jul 24, 2022
@bombasticSlacks bombasticSlacks merged commit 2e862f4 into CleverRaven:master Aug 3, 2022
alef pushed a commit to alef/Cataclysm-DDA that referenced this pull request Aug 6, 2022
* ALL_SEEING

* Relentless hulk smash

Co-authored-by: Venera3 <[email protected]>
@Venera3 Venera3 deleted the all_seeing branch September 11, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants