Graded steel weapons

[Drew4484]

Summary

Content "Graded Steel Blades"

Purpose of change

Adds grades of steel to bladed weapons.

Describe the solution

Adds versions of common bladed weapons using different grades of steel. A separate PR will add recipes.

Variants

• Arming Sword
• Broadsword
• Cavalry Sabre
• Cutlass
• Estoc
• Falx
• Jian
• Katana
• Kriegsmesser
• Longsword
• Nodachi
• Rapier
• Scimitar
• Wakizashi
• Zweihänder

Describe alternatives you've considered

None.

Testing

Debug spawned various examples and killed zombies with them.

Additional context

This will give some practice opportunities for the crafting proficiencies like tempering.
A draft showing how the improved crafting results in a blade that holds a sharp edge better, and improvements in the grip materials to represent the player having a higher technological base.

[OtpalTS]

The crafting tab needs to be seriously reworked, because once you try to tab past the weapons tab you will stutter like with food and armor tabs (not long but noticable).
Also there is the issue that these recipes blot out the crafting menu, meaning you need to either know what youre looking for and know what its named to use the search function or you spend ages looking at slight variations of items. Most of which won't ever be made since if you're already investing in a fairly complicated item with a decent craft time you will go for the best one.
This of course would be a large project that shouldn't block this or even 0.G. But I feel it should be mentioned, even though i truly think all these metallurgy PRs are extremely neat.

[Terrorforge]

No, I think that should block this. Don't get me wrong, I'm also excited about these expansions, but it's really not worth making the crafting menu borderline unusable. It's not just that they crowd out all the other recipes, the variants themselves aren't arranged in a sensible way. They're nowhere near each other and in no particular order, to the point where it's still confusing after you use the search feature. I know the weapons wouldn't be as bad since they don't also have the light/medium/heavy variants, but it's already enough of a problem that I don't want to see it made worse

A possible bandaid solution would be to put them in their own tab in the crafting meny, on the same level as "Weapon" and "Armor". That has it's own problems (e.g. some weapons not being in the "Weapon" tab), but it would keep the other tabs from getting cluttered and would help with the internal organization because you could have subtabs like "Mild steel", "Medium steel" etc. in an order that clearly communicates which materials are higher tier.

[Drew4484]

No, I think that should block this. Don't get me wrong, I'm also excited about these expansions, but it's really not worth making the crafting menu borderline unusable. It's not just that they crowd out all the other recipes, the variants themselves aren't arranged in a sensible way. They're nowhere near each other and in no particular order, to the point where it's still confusing after you use the search feature. I know the weapons wouldn't be as bad since they don't also have the light/medium/heavy variants, but it's already enough of a problem that I don't want to see it made worse

A possible bandaid solution would be to put them in their own tab in the crafting meny, on the same level as "Weapon" and "Armor". That has it's own problems (e.g. some weapons not being in the "Weapon" tab), but it would keep the other tabs from getting cluttered and would help with the internal organization because you could have subtabs like "Mild steel", "Medium steel" etc. in an order that clearly communicates which materials are higher tier.

Updating the entire crafting system is out of the scope of this PR, other people are already working on solutions for that. I agree that the menus are cluttered but that's currently unavoidable whether adding more melee options or food recipes.

[Drew4484]

@bombasticSlacks Before I do all the crafting recipes, mind looking at the damage values?

[Amoebka]

This completely breaks CVD upgrades, since that one is hardcoded to check for the default "steel" material. Not a difficult fix, but please don't forget it.
Are you going to make steel variants of bronze swords, too? There's no real reason a khopesh can't be forged out of tempered steel.

[Drew4484]

This completely breaks CVD upgrades, since that one is hardcoded to check for the default "steel" material. Not a difficult fix, but please don't forget it.
Are you going to make steel variants of bronze swords, too? There's no real reason a khopesh can't be forged out of tempered steel.

Yeah this initial list was thrown together pretty quickly. If you have suggestions, here's the criteria I'm using going forward.

The criteria should be purpose built as a cutting weapon: Survivor versions of existing weapons are fine, but not makeshift as those are going to be too flimsy to be worth the blade.
Cut should be the primary damage, the increases for these weapons are based on them having a hard edge that holds up under use.
One or two handed weapons are fine, it just increases the amount of material the grip uses. Likewise the entire weapon does not need to be metal, just the business end, like a spear.

[github-actions]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• This is a curved sword associated with various Middle Eastern and Central Asian countries. Designed for slashing, and quite deadly against unarmored targets. Features a blade of hardened steel and a non-conductive grip of kevlar reinforced with tough plastic resin to fit your hand better.
• This is a curved sword associated with various Middle Eastern and Central Asian countries. Designed for slashing, and quite deadly against unarmored targets. Features a blade of high carbon steel and a grip of leather wrapped in wire to fit your hand better.
• This is a curved sword associated with various Middle Eastern and Central Asian countries. Designed for slashing, and quite deadly against unarmored targets. Features a blade of medium carbon steel and a grip of leather wrapped in wire to fit your hand better.
• This is a curved sword associated with various Middle Eastern and Central Asian countries. Designed for slashing, and quite deadly against unarmored targets. Features a blade of tempered steel and a non-conductive grip of kevlar reinforced with tough plastic resin to fit your hand better.
• This is a curved sword associated with various Middle Eastern and Central Asian countries. Designed for slashing, and quite deadly against unarmored targets. The entire piece is made with mild carbon steel.
• This is a rare sword from Japan. Deadly against unarmored targets, and still very effective against armor. Features a blade of hardened steel and a non-conductive grip of kevlar reinforced with tough plastic resin to fit your hand better.
• This is a rare sword from Japan. Deadly against unarmored targets, and still very effective against armor. Features a blade of high carbon steel and a grip of leather wrapped in wire to fit your hand better.
• This is a rare sword from Japan. Deadly against unarmored targets, and still very effective against armor. Features a blade of medium carbon steel and a grip of leather wrapped in wire to fit your hand better.
• This is a rare sword from Japan. Deadly against unarmored targets, and still very effective against armor. Features a blade of tempered steel and a non-conductive grip of kevlar reinforced with tough plastic resin to fit your hand better.
• This is a rare sword from Japan. Deadly against unarmored targets, and still very effective against armor. The entire piece is made with mild carbon steel.
• This is an ancient Chinese doubled-edged straight sword, with an ornate guard and a tassel attached to the pommel. One of the four major weapons in folklore, alongside the dao sabre, qiang spear, and gun staff. Features a blade of hardened steel and a non-conductive grip of kevlar reinforced with tough plastic resin to fit your hand better.
• This is an ancient Chinese doubled-edged straight sword, with an ornate guard and a tassel attached to the pommel. One of the four major weapons in folklore, alongside the dao sabre, qiang spear, and gun staff. Features a blade of high carbon steel and a grip of leather wrapped in wire to fit your hand better.
• This is an ancient Chinese doubled-edged straight sword, with an ornate guard and a tassel attached to the pommel. One of the four major weapons in folklore, alongside the dao sabre, qiang spear, and gun staff. Features a blade of medium carbon steel and a grip of leather wrapped in wire to fit your hand better.
• This is an ancient Chinese doubled-edged straight sword, with an ornate guard and a tassel attached to the pommel. One of the four major weapons in folklore, alongside the dao sabre, qiang spear, and gun staff. Features a blade of tempered steel and a non-conductive grip of kevlar reinforced with tough plastic resin to fit your hand better.
• This is an ancient Chinese doubled-edged straight sword, with an ornate guard and a tassel attached to the pommel. One of the four major weapons in folklore, alongside the dao sabre, qiang spear, and gun staff. The entire piece is made with mild carbon steel.
• hardened broadswords
• hardened cutlasses
• hardened scimitars
• high steel broadswords
• high steel cutlasses
• high steel scimitars
• medium steel broadswords
• medium steel cutlasses
• medium steel scimitars
• mild steel broadswords
• mild steel cutlasses
• mild steel scimitars
• tempered broadswords
• tempered cutlasses
• tempered scimitars

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.