Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Park update #59145

Merged
merged 9 commits into from
Jul 11, 2022
Merged

Park update #59145

merged 9 commits into from
Jul 11, 2022

Conversation

LovamKicsiGazsii
Copy link
Contributor

@LovamKicsiGazsii LovamKicsiGazsii commented Jul 10, 2022

Summary

Content "Park update"

Purpose of change

Continues regional terrain project and roof project.
Brings down zombie spawns to more sensible levels.

Describe the solution

Added shingle roofs to pavilions and restrooms. More than halved zombie count for all park variants (from 10 - 20 to 1 - 10), no more guaranteed spawns. Specialized park types (like: dog parks, tennis courts) were given more descriptive names.

Also added streetlights and walkways to some variants. Sport courts are now guaranteed to spawn a ball of the appropriate type. Fixed vehicle spawns for park 3. Fixed toilets for park 1. Replaced rocks with bollards in some cases. General mapgen updates.

Describe alternatives you've considered

Adding tennis-related items for tennis courts.

Slides, monkey bars, bollards, and basketball hoops should be converted into furniture.

Testing

Debug-spawned in the world.

Additional context

Screenshots:

Playground
kép
Playground 1
kép
Dog park
kép
Park 1
kép
Park 2
kép
Park 3
kép
Park 4
kép
Park 5
kép
Park 6
kép
Park 7
kép

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods Issues related to mods or modding Mods: No Hope Relating to the mod No Hope json-styled JSON lint passed, label assigned by github actions labels Jul 10, 2022
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Jul 10, 2022
@PatrikLundell
Copy link
Contributor

PatrikLundell commented Jul 10, 2022

I'm all for a significant reduction of the park hordes, but 10-20 -> 1-10 is almost a third rather than half the number (average of 15 vs 5.5), so the numbers don't match what I interpret to be the values you intended (a straight halving would be 5-10).

@LovamKicsiGazsii
Copy link
Contributor Author

I'm all for a significant reduction of the park hordes, but 10-20 -> 1-10 is almost a third rather than half then number (average of 15 vs 5.5), so the numbers don't match what I interpret to be the values you intended (a straight halving would be 5-10).

Thanks for the heads up, I'll fix the description. It wasn't my intention to trisect it, but I'm content with the results.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 10, 2022
@dseguin dseguin merged commit 41b1786 into CleverRaven:master Jul 11, 2022
@LovamKicsiGazsii LovamKicsiGazsii deleted the park-update branch July 12, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: No Hope Relating to the mod No Hope Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants