Fix NPCs hitting allies with reach attacks #59071
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix NPCs hitting allies with reach attacks"
Purpose of change
Fixes #59056
Describe the solution
Before making a reach attack, have the NPC check for any
FRIENDLY
creatures in the way. If there are and the NPC is allowed to move, use theavoid_friendly_fire
method to attempt to maneuver around the ally. If there are but the NPC is not allowed to move, have them complain.Describe alternatives you've considered
Considered allowing
NEUTRAL
creatures to trigger the non-attack logic.Considered tying the check to the 'avoid shooting allies' rule.
Can do either or both of the above easily. Figured I'd start simple and respond to feedback.
Testing
Used various combinations of a friendly NPC with a spear/long pole and debug monster/player/npc geometry. Also tested with NPC riding shotgun in a vehicle to make sure they behave properly and don't move unexpectedly. Tested with a few combinations of combat rules, but my no means did that exhaustively.