Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Innawood] update map settings to include Forest and foliage overhaul #58540

Merged
merged 4 commits into from
Jun 20, 2022

Conversation

Light-Wave
Copy link
Contributor

Summary

Mods "Innawood uses Forest and foliage overhaul"

Purpose of change

Use changes from PR #54411
Use changes from PR #55892 and PR #55892
Hopefully doesn't add anything man made to the world gen.

Describe the solution

Updates innawood_map_settings.json and files in mapgen to include changes done in mainline, but still also include changes that Innawood wants to make to these files.

Describe alternatives you've considered

Testing

I made a map with these changes and teleported around a bit to see if anything looked out of the ordinary. Everything seemed to work as expected.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods Issues related to mods or modding Mods: Innawood 🌲 Anything to do with Innawood mod astyled astyled PR, label is assigned by github actions labels Jun 19, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 19, 2022
@dseguin dseguin merged commit d84d159 into CleverRaven:master Jun 20, 2022
@Sathra225
Copy link
Contributor

Sathra225 commented Jun 24, 2022

This seems to have prevented the wild crops (corn, pumpkin, etc) from spawning, as I don't think f_region_weed is called anywhere now.

@Light-Wave
Copy link
Contributor Author

This seems to have prevented the wild crops (corn, pumpkin, etc) from spawning, as I don't think f_region_weed is called anywhere now.

Good catch. PR #58695 should fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Innawood 🌲 Anything to do with Innawood mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants