Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a few recipes i missed in tailoring audit #58539

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

a-chancey
Copy link
Contributor

Oops

Summary

Bugfixes "Adds missing patchwork sheet recipes and a rename i missed"

Purpose of change

Fixes #58504
adds recipes for patchwork leather sheet, patchwork fur sheet, patchwork faux fur sheet, patchwork lycra sheet, patchwork synthetic fabric sheet and patchwork felt sheets.
Also fixes patchwork synthetic fabric naming.

Describe the solution

I added the recipes

Describe alternatives you've considered

making someone else do it.

Testing

I opened the game and created each of the items successfully.

Additional context

Oops.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 19, 2022
@TheShadowFerret
Copy link
Contributor

TheShadowFerret commented Jun 19, 2022

As this was the "patchwork clothing parts -> rag" recipe, shouldn't it also go now that the audit is in(also it doesn't work because of the migration to itself 😛)?
image

@a-chancey
Copy link
Contributor Author

I don't have time to get to it tonight - I'll try to take care of that tomorrow while the wife drives - but you're absolutely right.

I've got at least one other issue currently to clean up regarding the thread needed for weaving cotton cloth (it's way too low right now), so I'll make another issue addressing those tomorrow and hopefully get a PR put in by the evening. Those are both mostly just annoyance/balance issues at the moment.

The patchwork sheet recipes, on the other hand, were entirely intended in the first pass, as it's the only way to acquire said patchwork sheets. I kept this PR exclusively to the work outlined in the issue I filed

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 19, 2022
@bombasticSlacks bombasticSlacks merged commit 6e7d1a9 into CleverRaven:master Jun 19, 2022
@a-chancey a-chancey deleted the patchwork-sheet-fixes branch June 19, 2022 17:25
@Sathra225
Copy link
Contributor

Just to double-check, if I added an uncraft recipe for cotton sheets, they would uncraft into 8 patches? Largely an Innawoods thing as patches are currently somewhat annoying to get.

@a-chancey
Copy link
Contributor Author

You should be able to cut them up or disassemble them already, I’ll look into that if they’re unable to be.

Unless innawoods specifically has an override for the uncraft recipe, which is possible.

@Sathra225
Copy link
Contributor

Started a new world and character and both spawned in and crafted a cotton sheet. Couldn't disassemble them and cutting them up only gives a chance at a single patch.

@a-chancey
Copy link
Contributor Author

Thanks for testing it out. That’s odd, I’ll see what I can get to this weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Few missing material recipes in tailoring overhaul
4 participants