Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forest glass #58538

Merged
merged 15 commits into from
Jun 20, 2022
Merged

Forest glass #58538

merged 15 commits into from
Jun 20, 2022

Conversation

Sathra225
Copy link
Contributor

Summary

Mods "Forest Glass and Acetone"

Purpose of change

The ammonia changes made glass and rubber cement impossible in Innawoods, so these changes make them possible.

Describe the solution

Adds 'forest glass' made from sand, ash for flux and lime as stabiliser. It requires more heat and fuel than soda glass. Then added autolearn to acetone (all the other ingredients are already possible).

Describe alternatives you've considered

Changing the problematic recipes to using Innawoods craftable ammonia, but not sure if there are other changes coming on that front so went with alternative recipes.

Testing

Made changes, recipes were available and made.

Additional context

Viability of ash/forest glass is from https://etheses.whiterose.ac.uk/3464/1/287681.pdf.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mods Issues related to mods or modding Mods: Innawood 🌲 Anything to do with Innawood mod labels Jun 18, 2022
@Sathra225
Copy link
Contributor Author

The commit history is a mess after having to fix my repository.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 18, 2022
@Light-Wave
Copy link
Contributor

Lovely, thank you.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 19, 2022
@dseguin dseguin merged commit e642f08 into CleverRaven:master Jun 20, 2022
@Sathra225 Sathra225 deleted the forest-glass branch June 20, 2022 09:57
@evankimori
Copy link

Hi, question from a discussion on #59671 - is it possible perhaps to incorporate Corpse Ash into the recipes here? Or is this already a WIP?

Apologies if I'm asking a question already answered.

@Light-Wave
Copy link
Contributor

Hi, question from a discussion on #59671 - is it possible perhaps to incorporate Corpse Ash into the recipes here? Or is this already a WIP?

Not currently worked on, to my knowledge.
If you can show research showing that this works in real life, and perhaps numbers of how much corpse ash you need compared to how much wood ash you need, then I would be fine with including it in Innawood.
As far as I can tell, the composition in corpse ash and wood ash are different. However, the important part seems to be potash, which exists in roughly equal amounts in wood ash and cremated remains. So it is possible it would work. But I'd like a slightly more definitive source than that. If you find that, you can make an issue and ping me in it (with @), or you can reply here.

@Sathra225
Copy link
Contributor Author

The corpse ash in-game is wildly variable which is a problem. Bone ash would work (and I think it was used as a replacement for lime in glass generally) but 'corpse ash' also comes from chitin, flesh and alien carapace.
So while it could work, it would result in really poor glass (well, poorer) due to all the impurities that come with flesh char. It'd probably make more sense to use corpse ash as fertiliser honestly.

This PR was already merged so its not being worked on.

@evankimori
Copy link

It'd probably make more sense to use corpse ash as fertilizer honestly.

Hrm. That's a very good thought. Will discuss. Thank you for your input and clarification, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Innawood 🌲 Anything to do with Innawood mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants