Correct logic for -Wno-unknown-warning-option #58523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like both AppleClang and LLVM Clang use -Wno-unknown-warning-option instead of -Wno-unknown-warning, so this updates the logic from b1e5ada to match that. It'd probably also be possible to just add both -Wno-unknown-warning and -Wno-unknown-warning-option, but who knows.
github-actions
bot
added
Code: Build
Qrox
reviewed
Jun 19, 2022
Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
It looks like both Apple-Clang and LLVM Clang use
-Wno-unknown-warning-optioninstead of-Wno-unknown-warning, so #57984 broke compilation (at least for my setup) due to itsCMAKE_CXX_COMPILER_IDbeingAppleClang.Describe the solution
This updates the logic from b1e5ada to match for both
AppleClangandClang(see https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_COMPILER_ID.html).Describe alternatives you've considered
It'd probably also be possible to just add both
-Wno-unknown-warningand-Wno-unknown-warning-optionand hope that that works, but this seems a bit safer.Testing
Compilation worked fine on my machine, hoping that CI catches any other issues. @alef, if possible could you also confirm that this looks okay for what you were going for?
Additional context
See also #57984.