Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add First Version of Portal Storm Dungeons #58500

Merged
merged 40 commits into from
Jul 1, 2022

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Jun 17, 2022

Summary

None

Purpose of change

Part of #52475
Related to #55794
Adds first version of portal dungeons, c++ needed to support it.

Describe the solution

Added spawn of portal dungeon and a mission to go find it to start of portal storm.
When found it has a teleporter to take you into the portal storm dungeon. The dungeon is partially randomly generated and changes while you are in it. A new enemy chases you and respawns after a while if killed, in addition lesser enemies spawn per level. You can find another teleporter to return you to the start which increases the level slightly increasing difficulty. Next to the entrance is the exit. When you leave you get a reward based on how far you make it into the dungeon.

Right now there are only 3 rewards. An effect lasting 2 days to increase dex, an item to give you a brief respite from danger, and a shadow summon that usually respawns on its death.

Describe alternatives you've considered

Getting even further along before putting this out there. I'd rather get the c++ and bulk of the work in early rather than later.

Testing

Additional context

Right now the balance is not finetuned and the concepts are a bit simple. Future work is planned to make the dungeon more random/interesting/challenging and to do more work with rewards/goals of the dungeon.

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON [Markdown] Markdown issues and PRs EOC: Effects On Condition Anything concerning Effects On Condition Lore Game lore, in-game communication. Also the Lore tab. Map / Mapgen Overmap, Mapgen, Map extras, Map display Mechanics: Enchantments / Spells Enchantments and spells Missions Quests and missions Monsters Monsters both friendly and unfriendly. NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Jun 17, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 17, 2022
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • You hear a curious voice saying "Do you hope to damage the very fabric of yourself, in a way that you misperceive as beneficial?"

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions and removed astyled astyled PR, label is assigned by github actions labels Jun 18, 2022
data/json/snippets/effect_on_conditions.json Outdated Show resolved Hide resolved
data/json/npcs/missiondef.json Outdated Show resolved Hide resolved
data/json/snippets/effect_on_conditions.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 18, 2022
@anoobindisguise
Copy link
Contributor

These are really cool. This could even be the place to reintroduce those artifact clothing/armor pieces, if it's the case that the netherworld/wherever these dungeons are "imprint" on reality, thoughts and concepts have influence on them right? That's why artifacts take the form of weird Earth objects like a can of silly string or a haircomb or whatever. Dungeons have magical loot, right? So whatever force or consciousness coalesces dimensions into a "dungeon" might feature those, and while it's not literal psychic powers, a pair of gauntlets that slightly alter reality in such a way that resembles "gauntlets of ogre strength" might actually fly, just like how you have a temporary dexterity boost arising from a weird alteration to your metaphysical state.

This might be delusional and entirely misunderstanding how netherum/artifacts work. And it's also asking more work of you when you already have done a ton. Can't wait to try these and then die horribly, I'm really excited for "roguelike dungeons" in this former roguelike to make an appearance.

@Ramza13
Copy link
Contributor Author

Ramza13 commented Jun 24, 2022

These are really cool. This could even be the place to reintroduce those artifact clothing/armor pieces, if it's the case that the netherworld/wherever these dungeons are "imprint" on reality, thoughts and concepts have influence on them right? That's why artifacts take the form of weird Earth objects like a can of silly string or a haircomb or whatever. Dungeons have magical loot, right? So whatever force or consciousness coalesces dimensions into a "dungeon" might feature those, and while it's not literal psychic powers, a pair of gauntlets that slightly alter reality in such a way that resembles "gauntlets of ogre strength" might actually fly, just like how you have a temporary dexterity boost arising from a weird alteration to your metaphysical state.

This might be delusional and entirely misunderstanding how netherum/artifacts work. And it's also asking more work of you when you already have done a ton. Can't wait to try these and then die horribly, I'm really excited for "roguelike dungeons" in this former roguelike to make an appearance.

I hadn't thought of doing artifacts in general for this, honestly I've never encountered an in game artifact so I forget they exist. That's potentially a great idea, I should check artifacts out. Would want to add some new draw back, maybe they need to go in portal storms to recharge or decay eventually or something. I don't have the total details worked out but I do want to add twists to the rewards that keep you coming back into contact with the nether.

src/creature.cpp Outdated Show resolved Hide resolved
src/talker.h Outdated Show resolved Hide resolved
src/game.cpp Show resolved Hide resolved
src/savegame.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Jun 26, 2022
@Theawesomeboophis
Copy link
Contributor

This is such a neat idea, I feel like mods could use this to amazing effect to create some really unique situations for the player to get themselves into.

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Jun 27, 2022
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 28, 2022
@Ramza13
Copy link
Contributor Author

Ramza13 commented Jun 28, 2022

This is such a neat idea, I feel like mods could use this to amazing effect to create some really unique situations for the player to get themselves into.

Yea one of the things I hope is that portal storms can serve as a blueprint for what is possible with just json, and provide examples of how to do it.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 28, 2022
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 28, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 30, 2022
@kevingranade kevingranade merged commit 8b678c8 into CleverRaven:master Jul 1, 2022
@Ramza13 Ramza13 deleted the portal_dungeons branch July 2, 2022 01:46
Drew4484 pushed a commit to Drew4484/Cataclysm-DDA that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Lore Game lore, in-game communication. Also the Lore tab. Map / Mapgen Overmap, Mapgen, Map extras, Map display [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells Missions Quests and missions Monsters Monsters both friendly and unfriendly. NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants