Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ablative armor can cover more than base armor #58331

Merged
merged 2 commits into from
Jun 11, 2022

Conversation

bombasticSlacks
Copy link
Contributor

@bombasticSlacks bombasticSlacks commented Jun 10, 2022

Summary

Features "Ablative armor can cover more than base armor"

Purpose of change

needed for #58020. Makes it so things like visors can extend an armors coverage.

Describe the solution

  • Item covered tests now also check if any of the ablative armor attached covers that bit too.
  • Simplified the logic for armor significantly. Now it applies ablative armor (or tries to) then checks if the armor itself protects.
  • Got rid of an incorrect bit of logic that normalized coverage values for ablative armor. The rolls weren't randomized so it didn't make sense. Just using the values as they are works fine.
  • Added a unit test to make sure that ablative armor that covers additional locations does protect you.

Describe alternatives you've considered

Testing

This one has a unit test to check if it is working!

Additional context

SOON
image
image

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 10, 2022
@dseguin dseguin merged commit c56004c into CleverRaven:master Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants