Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename vehicle::__part_removal_actual() #58293

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Rename vehicle::__part_removal_actual() #58293

merged 1 commit into from
Jun 9, 2022

Conversation

BrettDong
Copy link
Member

@BrettDong BrettDong commented Jun 9, 2022 •
edited
Loading

Summary

None

Purpose of change

#56143 triggers the "reserved identifier" clang-tidy warning that is enabled in #58200.

Describe the solution

Rename vehicle::__part_removal_actual() to vehicle::do_remove_part_actual().

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Vehicles Vehicles, parts, mechanics & interactions json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 9, 2022
@bombasticSlacks bombasticSlacks merged commit 0881332 into CleverRaven:master Jun 9, 2022
bombasticSlacks pushed a commit to bombasticSlacks/Cataclysm-DDA that referenced this pull request Jun 10, 2022
@BrettDong @bombasticSlacks
Rename vehicle::__part_removal_actual() (CleverRaven#58293)
0f5fe12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrettDong @bombasticSlacks