Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Innawood] fix bronze nail recipe #58284

Merged
merged 1 commit into from
Jun 9, 2022
Merged

[Innawood] fix bronze nail recipe #58284

merged 1 commit into from
Jun 9, 2022

Conversation

Light-Wave
Copy link
Contributor

@Light-Wave Light-Wave commented Jun 8, 2022 •
edited
Loading

Summary

None

Purpose of change

Fixes #58279

Describe the solution

Makes bronze nails use prof_redsmithing, casting_mold, one crucible and Grinding level 2 instead of prof_blacksmithing, hotcut, and two crucibles

Describe alternatives you've considered

Not 100% sure Grinding level 2 is needed. But it's used for other sharp bronze items, so may as well include it here as well.

Testing

Opened the game and checked the recipe. Looked good.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mods Issues related to mods or modding Mods: Innawood 🌲 Anything to do with Innawood mod json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 8, 2022
@Light-Wave
Copy link
Contributor Author

As far as I can tell, all failures are about density and unrelated to this PR. This should be fine to merge.

@NetSysFire
Copy link
Member

I can confirm that there are known problems with the density check. See #54811

@dseguin dseguin merged commit 1721e4c into CleverRaven:master Jun 9, 2022
bombasticSlacks pushed a commit to bombasticSlacks/Cataclysm-DDA that referenced this pull request Jun 10, 2022
@Light-Wave @bombasticSlacks
Update construction.json (CleverRaven#58284)
dba0841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maleclypse Maleclypse Maleclypse approved these changes

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Innawood 🌲 Anything to do with Innawood mod Mods Issues related to mods or modding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Innawood bronze nails creation path
4 participants
@Light-Wave @NetSysFire @Maleclypse @dseguin