Ensure strict weak ordering in scored_address::operator>()

[BrettDong]

Summary

None

Purpose of change

• Fix Crash in test "find_overmap_path_bridge" in Debug build #56906

The comparator in a std::priority_queue has to obey strict weak ordering, otherwise it's going to cause undefined behaviour. The greater operator of scored_address does not meet this condition:

bool operator> ( const scored_address &other ) const {
    return score >= other.score;
}

A > B and B > A are simultaneously true when their scores are equal and this violates the strict weak ordering requirement.

This causes assertion failure and crashes the program in MSVC Debug build as well as in _GLIBCXX_DEBUG mode in GCC.

Describe the solution

Change the greater operator of scored_address to do strict greater comparison of score field.

1. This does not seems to affect the semantic of maintaining a min heap priority queue in the A-star algorithm.
2. The current behaviour is undefined anyway.
3. The order of elements of equal priority in a std::priority_queue is undefined anyway.

Describe alternatives you've considered

Testing

Additional context