Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard hat/helmet attachments #58204

Closed

Conversation

Termineitor244
Copy link
Contributor

@Termineitor244 Termineitor244 commented Jun 6, 2022

Summary

Content "Adds hard hats/helmets attachments"

Purpose of change

Continuation of #58020 and part of #58025.
Many helmets or hard hats can have attachments and modifications, it's time for it to become reality in cataclysm too.

Examples of planned add-ons for hard hats:
Sun shields
Face Shield and Mounting Bracket
Shield Visor
Ear Muffs
Ballistic Mandible Guard
Counterweight Pouch

Describe the solution

Adds many new attachments for hard hats helmets, as well as the pockets that will accommodate these new items in the helmets/hard hats.

I also modified the hooded hard hat to now use a sun shield, and added a neck protector attachment in place of the hooded hard hat.

PROTECTION/COVERAGE VALUES ARE WIP UNTIL I GO AROUND TESTING THEM

Describe alternatives you've considered

To not add them?

Testing

TO BE DONE.

Additional context

Thanks @bombasticSlacks for the help with making these new ablative pockets to work!

That and adding some spawns/recipes, as well as adding the new pockets to the rest of the helmets.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 6, 2022
@bombasticSlacks
Copy link
Contributor

bombasticSlacks commented Jun 6, 2022

Well if you've already got the json done I can try to do the infrastructure tomorrow if you would like?

I think I have an idea for how to do it in an easy way.

@Termineitor244
Copy link
Contributor Author

Well if you've already got the json done I can try to do the infrastructure tomorrow if you would like?

I think I have an idea for how to do it in an easy way.

I would be very grateful if you did!

@TheShadowFerret
Copy link
Contributor

Are any of these going to be craftable? Otherwise, non-master craftsmen need a repairs_like.

@Termineitor244
Copy link
Contributor Author

Are any of these going to be craftable? Otherwise, non-master craftsmen need a repairs_like.

At the very least the pouch will be craftable, the face shields too if I can base myself around some similar recipe, and the earmuffs maybe...

But anyways, I had forgotten about repairs_like, thanks for reminding me, I will add some after getting out of work.

@vonschtirlitz
Copy link

Oh man love this addition, I'll see if I can add something or contribute irl data!

Just playing super detail attentive devil's advocate here, most if not all civilian hard hats aren't really able to take specialty military attachments (counterweights, mandibles, etc). The ones I've seen can take earpro, and then smaller faceshields for tree work and the like. Ballistic helmets usually use proprietary interfaces to attach more involved items like mandibles and face shields, which do not work across different brands of helmets (example 1, example 2), much less civilian hard hats.

Are we supposing that there is now one magic helmet attachment standard for civillian and military helmets? Or is it perhaps worth restricting some attachments to certain helmets, thereby adding some choice consideration, perhaps if you wanted a lighter, more modular helmet, versus a plain helmet that has more ballistic protection.

Either way, this looks super exciting and I'll try to contribute something as well! 😋

@Termineitor244
Copy link
Contributor Author

Oh man love this addition, I'll see if I can add something or contribute irl data!

Any one of those would be helpful! Thanks!

Just playing super detail attentive devil's advocate here, most if not all civilian hard hats aren't really able to take specialty military attachments (counterweights, mandibles, etc). The ones I've seen can take earpro, and then smaller faceshields for tree work and the like. Ballistic helmets usually use proprietary interfaces to attach more involved items like mandibles and face shields, which do not work across different brands of helmets (example 1, example 2), much less civilian hard hats.

The face shield example I gave above in the description is, in fact, a face shield made for hard hats! With the mandible attachment I'm going more for the "You could kind of adapt one to use straps for hard hats, it wouldn't be ideal, but it would allow you to wear it without a military helmet". The counterweight has 2 links on the description, in one of those links the pouch is just hanging from some wire wrapped around your helmet, so why not use something similar for most helmets/hard hats?

Are we supposing that there is now one magic helmet attachment standard for civillian and military helmets? Or is it perhaps worth restricting some attachments to certain helmets, thereby adding some choice consideration, perhaps if you wanted a lighter, more modular helmet, versus a plain helmet that has more ballistic protection.

Well, there are going to be some compromises for the sake of simplicity, like assuming all military helmets have the interfaces needed for these kind of military attachments, but I definitely want to limit the possible attachments depending on the helmet, mainly because of shape, but without limiting too much if I can help it, specially since I want the attachments to cover most of the sublocations that the helmets will not cover after they undergo an update to he sublimb system.

Either way, this looks super exciting and I'll try to contribute something as well! 😋

Thank you! I'm glad you are on board with the idea!

@bombasticSlacks
Copy link
Contributor

Are we supposing that there is now one magic helmet attachment standard for civillian and military helmets?

We do this for gun mods currently, no differentiation between Picatinny rails, mlok, Russian side mounts etc.

For a lot of this stuff it's getting into "too detailed" territory. This isn't Escape From Tarkov you shouldnt need a spread sheet to match face shields with military helmets IMO at least.

Another way to think about this is realistically there will probably only be 3-4 military helmets. High cut w. Attachment points, ears covering w. Attachment points, maybe a high end or sci Fi helm made of better materials, and then 1-2 helmets without attachment points. So there are only realistically going to be 2-3 helmets most people will use so going nuts on differentiation doesn't make much sense.

@vonschtirlitz
Copy link

I'm going more for the "You could kind of adapt one to use straps for hard hats, it wouldn't be ideal, but it would allow you to wear it without a military helmet"

Ok yeah I see what you mean. I should also probably take into account the crazy mad scientist engineer survivor who can probably duct tape stuff to his helmet to attach it instead of using fancy "pockets" and attachment points. This would probably also make improvised applique armor (like football helmet front cage) pretty viable and accessible early game.

We do this for gun mods currently, no differentiation between Picatinny rails, mlok, Russian side mounts etc.

I'm completely on the same page and I agree with this approach, but it would feel weird to be able to freely click in some ballistic face shield or future AR goggles onto some random hard hat or bike helmet you found. Perhaps if you were to modify the helmet to add additional proper slots or something it would make sense, versus a military helmet coming standard with those. I haven't touched CDDA in a few months recently, but I remember there being either a mod or some other system that allowed you to add additional weapon modification slots to weapons that didn't have them to begin with. Maybe something along the lines of that.

@bombasticSlacks
Copy link
Contributor

I'm completely on the same page and I agree with this approach, but it would feel weird to be able to freely click in some ballistic face shield or future AR goggles onto some random hard hat or bike helmet you found.

if you look at what is done in this PR there are new mount points actually defined. So a bike helmet just wouldn't have slots. A helmet that covers the ears wouldn't have ear slots but could have a visor slot. ETC. This system is very opt-in not opt-out when it comes to including items in it 😆

I'm not 100% convinced on the mandibles for hard hats but at worst it could be revisited in the future IMO once more options have these mount points.

@Termineitor244
Copy link
Contributor Author

I plan on changing the hooded hard hat to be one that uses a sun guard, and make a new attachment for a nape protector (To replace the original hooded hard hat).

The new hard hat with sun guard will be the same as the normal version, but with a sunglasses effect and somewhat less possible attachments (Because of its size mainly).

@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 8, 2022
@toweroglass
Copy link

Perhaps if you were to modify the helmet to add additional proper slots or something it would make sense, versus a military helmet coming standard with those. I haven't touched CDDA in a few months recently, but I remember there being either a mod or some other system that allowed you to add additional weapon modification slots to weapons that didn't have them to begin with. Maybe something along the lines of that.

I like this solution a lot. would seem more in line with the way we mod old guns to make them more "tacticool". a kit to attach mandibles to a hard hat could just require some plastic chunks and the mandible to be used as a tool for reference. Obviously i over simplified the recipe but something like that.

Early game I always dream i could combine a mining helmet and a hooded hard hat. Seems like this kind of modularity shouldn't be difficult. some of the mix and match situations might not make sense irl, but in game it stands to reason you would be making the most with what you come across.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 12, 2022
@github-actions github-actions bot added the Crafting / Construction / Recipes Includes: Uncrafting / Disassembling label Jun 12, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Jun 12, 2022
@github-actions github-actions bot added Code: Build Issues regarding different builds and build environments Code: Tests Measurement, self-control, statistics, balancing. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Info / User Interface Game - player communication, menus, etc. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Containers Things that hold other things Items: Magazines Ammo holding items and objects. Map / Mapgen Overmap, Mapgen, Map extras, Map display Mechanics: Weather Rain, snow, portal storms and non-temperature environment Melee Melee weapons, tactics, techniques, reach attack Missions Quests and missions Mods: Aftershock Anything to do with the Aftershock mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: Generic Guns Anything to do with Generic Guns Mods: Innawood 🌲 Anything to do with Innawood mod Mods: Magiclysm Anything to do with the Magiclysm mod Monsters Monsters both friendly and unfriendly. NPC / Factions NPCs, AI, Speech, Factions, Ownership SDL: Tiles / Sound Tiles visual interface and sounds. Spawn Creatures, items, vehicles, locations appearing on map Translation I18n Vehicles Vehicles, parts, mechanics & interactions and removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 26, 2022
@Termineitor244 Termineitor244 deleted the Hard-hat-attachments branch June 26, 2022 19:36
@Termineitor244 Termineitor244 restored the Hard-hat-attachments branch June 26, 2022 19:37
@Termineitor244 Termineitor244 deleted the Hard-hat-attachments branch June 26, 2022 19:39
@Termineitor244
Copy link
Contributor Author

Termineitor244 commented Jun 26, 2022

This branch got broken, so I moved my changes to #58749.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions Bionics CBM (Compact Bionic Modules) [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world Code: Build Issues regarding different builds and build environments Code: Tests Measurement, self-control, statistics, balancing. Code: Tooling Tooling that is not part of the main game but is part of the repo. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Documentation> Design documents, internal info, guides and help. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Info / User Interface Game - player communication, menus, etc. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Armor / Clothing Armor and clothing Items: Containers Things that hold other things Items: Magazines Ammo holding items and objects. [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display [Markdown] Markdown issues and PRs Mechanics: Weather Rain, snow, portal storms and non-temperature environment Melee Melee weapons, tactics, techniques, reach attack Missions Quests and missions Mods: Aftershock Anything to do with the Aftershock mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: Generic Guns Anything to do with Generic Guns Mods: Innawood 🌲 Anything to do with Innawood mod Mods: Magiclysm Anything to do with the Magiclysm mod Monsters Monsters both friendly and unfriendly. NPC / Factions NPCs, AI, Speech, Factions, Ownership [Python] Code made in Python SDL: Tiles / Sound Tiles visual interface and sounds. Spawn Creatures, items, vehicles, locations appearing on map Translation I18n Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.