Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mouse scrolling to all scrollable_text() windows (help, NPC epilogue, faction epilogue, some NPC talk) #58145

Merged

Conversation

leemuar
Copy link
Contributor

@leemuar leemuar commented Jun 4, 2022

Summary

Features "You can now use mouse to scroll help windows, NPC epilogue, factions epilogue"

Purpose of change

Increase usability by adding mouse commands to UI.
Contributes to #58106

Describe the solution

Add SCROLL_UP and SCROLL_DOWN actions to all windows calling scrollable_text(). They work exactly like UP and DOWN commands: scroll by 1 line

Describe alternatives you've considered

Testing

  • open HELP menu (0) -> m
  • make sure mouse wheel scrolls text up and down

Additional context

This includes:
- help texts (```0```)
- NPC epilogues
- faction epilogues
- some NPC talks as popup message
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 4, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 4, 2022
@ZhilkinSerg ZhilkinSerg merged commit f3da0cb into CleverRaven:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants