Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mouse up and down scrolling to message log window (P by default) #58124

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

leemuar
Copy link
Contributor

@leemuar leemuar commented Jun 3, 2022

Summary

Features "You can now scroll message log window up and down using mouse wheel or touchpad"

Purpose of change

Increase usability by adding mouse commands to UI.
Contributes to #58106

Describe the solution

Add SCROLL_UP and SCROLL_DOWN actions to the message log window. They work exactly like UP and DOWN commands: scrolling by 1 line

Describe alternatives you've considered

Testing

  • launch the game
  • make a lot of different actions to fill up the message log
  • open message log window (P by default)
  • make sure scrolling mouse wheel up scrolls messages upwards
  • make sure scrolling mouse wheel down scrolls messages downwards

Additional context

video_2022-06-03_22-49-23.mp4

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions labels Jun 3, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 3, 2022
@Maleclypse Maleclypse added the Info / User Interface Game - player communication, menus, etc. label Jun 4, 2022
src/messages.cpp Outdated Show resolved Hide resolved
src/messages.cpp Outdated Show resolved Hide resolved
src/messages.cpp Outdated Show resolved Hide resolved
src/messages.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 6, 2022
@dseguin dseguin merged commit 7e8b40a into CleverRaven:master Jun 7, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 7, 2022
bombasticSlacks pushed a commit to bombasticSlacks/Cataclysm-DDA that referenced this pull request Jun 10, 2022
…leverRaven#58124)

* Add mouse up and down scrolling to message log window (P by default)

* Astyle

* More astyle

Co-authored-by: Тимур Кашафутдинов <[email protected]>
Co-authored-by: Zhilkin Serg <[email protected]>
Co-authored-by: David Seguin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants