Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sew_advanced from the tailor kits #58035

Merged
merged 1 commit into from
May 31, 2022

Conversation

bombasticSlacks
Copy link
Contributor

Summary

Balance "Remove sew_advanced from the tailor kits"

Purpose of change

sew_advanced is a weird system that doesn't make a lot of sense. The ability to take any clothing and pad it thick, not leading to additional layer conflicts, taking very little time and being better than normal armor is silly. A lot of work has been put into making and supporting real armor and layering, this system detracts from it.

Specific things that really push it over the edge

  • Most clothing going to 100% coverage
  • Most recipes taking a lot longer to complete
  • More in depth and nuanced armor
  • A push towards wearing more layers for warmth, or for protection

Describe the solution

Remove the sew_advanced function from the tailor kits in base game and magiclysm (IDK if innawoods would also want the removal) so this can still exist in 3rd party where it doesn't need to be a balance consideration.

Describe alternatives you've considered

I could currently go through and delete all the code and support. I would like to do this in the future as supporting padding armor is really cumbersome on a lot of otherwise straightforward parts of the code making them confusing and intuitive. However for now it should still be supported for 3rd party mods.

Out of the scope of this PR I would like to in the future work on a system where you can learn the basic pattern for sewing something like a tshirt or pauldrons and then those recipes could define a list of primary materials they can be made of (lycra, cotton, nylon) (various types of steel). This would let you create higher end clothing out of nicer materials for end game (though properly manufactured stuff should still probably edge it out.

There was some discussion of making this system "good enough" but it would require basically a complete rewrite of this whole system so that it has parity with the normal armor system. However because of how it is designed this would also require maintaining both separately which would be a pile of work. Beyond that I think that this system if I put in all the work to balance it and support it would just be worse than wearing normal purpose built clothing making it an even larger waste of time.

Testing

if it passes JSON it should be good.

Additional context

image

@bombasticSlacks bombasticSlacks requested a review from KorGgenT as a code owner May 30, 2022 20:44
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 30, 2022
@dseguin dseguin merged commit db95b82 into CleverRaven:master May 31, 2022
bombasticSlacks added a commit to bombasticSlacks/Cataclysm-DDA that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants