remove sew_advanced from the tailor kits #58035
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Balance "Remove sew_advanced from the tailor kits"
Purpose of change
sew_advanced is a weird system that doesn't make a lot of sense. The ability to take any clothing and pad it thick, not leading to additional layer conflicts, taking very little time and being better than normal armor is silly. A lot of work has been put into making and supporting real armor and layering, this system detracts from it.
Specific things that really push it over the edge
Describe the solution
Remove the sew_advanced function from the tailor kits in base game and magiclysm (IDK if innawoods would also want the removal) so this can still exist in 3rd party where it doesn't need to be a balance consideration.
Describe alternatives you've considered
I could currently go through and delete all the code and support. I would like to do this in the future as supporting padding armor is really cumbersome on a lot of otherwise straightforward parts of the code making them confusing and intuitive. However for now it should still be supported for 3rd party mods.
Out of the scope of this PR I would like to in the future work on a system where you can learn the basic pattern for sewing something like a tshirt or pauldrons and then those recipes could define a list of primary materials they can be made of (lycra, cotton, nylon) (various types of steel). This would let you create higher end clothing out of nicer materials for end game (though properly manufactured stuff should still probably edge it out.
There was some discussion of making this system "good enough" but it would require basically a complete rewrite of this whole system so that it has parity with the normal armor system. However because of how it is designed this would also require maintaining both separately which would be a pile of work. Beyond that I think that this system if I put in all the work to balance it and support it would just be worse than wearing normal purpose built clothing making it an even larger waste of time.
Testing
if it passes JSON it should be good.
Additional context