Work towards Deprecating "melee_cut"

[Maleclypse]

Summary

None

Purpose of change

Make all bonus damage follow the "melee_damage" array format. I believe this will eliminate confusion in monster making by standardizing. Standardizing should also help prepare the way for jsonized damage types in post 0.G.

Describe the solution

Well the capture wildcards find and replace failed but it gave me the idea of replacing everything in a way that allows me to easily go in and modify each line and I can then easily check when I've completed a given file. But it's basically just find and replace.

Describe alternatives you've considered

Not doing this, but I think it's important.

Testing

Tests should continue to fail extensively until I've fixed everything I broke in the original find and replace :)

Additional context

This won't break third party mods but if melee_cut is phased out it will.

[Maleclypse]

I think I'll need to add the tropicataclysm folder to my project folders and do the same for their monsters.

[Maleclypse]

@dseguin You might know a way for me to do the find and replace with the old value for "melee_cut": '*', wildcarded so it replaces easily?

[NetSysFire]

If this is on Linux (or at least WSL) you can use sed:

sed 's/"melee_cut": \([0-9]\+\),/"melee_damage": [ { "damage_type": "cut", "amount": \1 } ],/g'

Anything that uses regex replace can do this.

[LyleSY]

Is it/will it be possible then to change some of these damage types? Right now all dinos do bonus cut damage if they do bonus damage, but it would be better if the damage type matched the dino. For example a dino that rams or smashes should be bashing.

[Maleclypse]

Is it/will it be possible then to change some of these damage types? Right now all dinos do bonus cut damage if they do bonus damage, but it would be better if the damage type matched the dino. For example a dino that rams or smashes should be bashing.

It's already possible but no one has gone through and updated old monsters to use "melee_damage": [ { "damage_type": "cut", "amount": 1 } ], the damage type in that array can be any existing damage type and that's why I think it's best to deprecate "melee_cut" because it's existence always ends up confusing me when I want to add bonus damage of other types.

[LyleSY]

DinoMod stuff looks good. I'll add specific damage types in a followup PR, I'll try and pull in some vanilla ones too

[Maleclypse]

Need to understand if melee_damage is supported in proportional and relative and if not I will need to undo any of the changes to those two values and melee_cut won't be able to be fully deprecated yet.

[github-actions]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• mavka
• mavkas

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.