Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast and toad in a hole Fix #57722

Merged

Conversation

SamGondra
Copy link
Contributor

Summary

Bugfixes "Fix/Update Toast and toad_in_a_hole"

Purpose of change

Makes the toad in a hole recipe use heat and a proper tool to actually cook. Also adds some Proficiencies and makes the buttered/jam/etc. Toasts use previously toasted bread instead of toasting the bread themselves.

Describe the solution

Made the toad-in-a-hole recipe a recipe on its own, since it needs a different cooking implement anyway than just just making toast, which you could conceivably do by using a skewer.
Also added Proficiencies and a bit of oil/butter for frying since I was at it, and gave the wheat free version all the wheat free breads.
Discovered that the different Jam/peanutbutter/butter versions all tried to copy from the recipe that was toasting the respective bread, but because of how copy from works in that it didn't copy over tools and qualities (I do not know how this works/if it ever worked like that). adjusted recipes to use the respective toasted bread instead, and tried to make sure everything has the right materials for fructose/grain/lactose intolerance.

Describe alternatives you've considered

Dropping all the extra recipes besides toasting bread and toad in the hole and just adding toast as possible (Bread)component for sandwiches, but that should probably increase fun of the products more than standard bread and my Brain is colse to rebelling anyway.
Also wondered if I should take crackers out of the toad in the hole recipe as possible bread, but brain said no.

Testing

Did make sure the recipes loaded in game and the recipes and products looked right.
("LIST" is a suprisingly important argument (Sorry again peeps in #dev-help))

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions labels May 15, 2022
@SamGondra SamGondra changed the title Sam gondra toast and toad in a hole Tast and toad in a hole Fix May 15, 2022
@SamGondra SamGondra changed the title Tast and toad in a hole Fix Toast and toad in a hole Fix May 15, 2022
@Inglonias
Copy link
Contributor

Inglonias commented May 16, 2022

Just a heads-up. The recipe described in game is not called "toad-in-a-hole" as far as I know. It's common name is "eggs in the basket". Toad in a hole is something different.

I figure as long as we're changing things a bit, we may as well fix the name...

@SamGondra
Copy link
Contributor Author

Just a heads-up. The recipe described in game is not called "toad-in-a-hole" as far as I know. It's common name is "eggs in the basket". Toad in a hole is something different.

I figure as long as we're changing things a bit, we may as well fix the name...

I am aware of that and had asked in discord - the setting is in new England though and there is apparently an 'american' version with the same name that is how this recipe is described.
Although I guess I could add a blurb in the description noting the difference.

@Maleclypse
Copy link
Member

Just a heads-up. The recipe described in game is not called "toad-in-a-hole" as far as I know. It's common name is "eggs in the basket". Toad in a hole is something different.

I figure as long as we're changing things a bit, we may as well fix the name...

It is called toad in a whole in parts of America and a quick google search would show you many of the recipes for it are the same as Egg in the basket. https://www.huffpost.com/entry/toad-in-a-hole-egg-in-a-basket-worthy_n_6994866

If I google "toad in the hole" while the top three links are for classic english toad in the hole less than halfway down the first page it shows an egg in a hole in a piece of toast. I'm wondering if that's altered for region, it's entirely possible.

@Maleclypse
Copy link
Member

I left out my thoughts that the original Toad in the Hole would likely only be found in Classic English Cooking books rather than something that could be autolearned and might as well then be called "Classic English Toad in the Hole".

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label May 19, 2022
@SamGondra
Copy link
Contributor Author

Added a remark in the description about the difference to the english version of the recipe, although it does not feel particular elegant.

@worm-girl
Copy link
Contributor

Why not name the food what it's generally called in America (eggs in a basket) since that's both where the game takes place and also the clearest solution? Then if someone wants to add proper toad in the hole later there's not a conflict.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 28, 2022
@dseguin dseguin merged commit 83aa029 into CleverRaven:master May 30, 2022
@SamGondra SamGondra deleted the SamGondra-Toast-and-toad_in_a_hole branch May 30, 2022 09:01
@NetSysFire NetSysFire added the Items: Food / Vitamins Comestibles and drinks label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants