Traders have trading standards #57660

stubkan · 2022-05-13T00:15:37Z

Traders have better trading standards - Pay less for filthy, damaged items, wont sell stuff for free and barter more sensibly.

Summary

Balance "Traders have better trading standards - Pay less for filthy, damaged items, wont sell stuff for free and barter more sensibly."

Purpose of change

It is really easy to cheese the trading system by just mass-selling filthy trash you get from corpses - especially soldier zombies. And no sensible shopkeeper wants to fill their store up with torn apart filthy bloodsoaked broken shoes and gloves. Or give away their stock for nothing. Or let you sell something to them for more than you just bought it from them for.

So the changes proposed will make that harder to do, making traders behave more sensibly, closing exploits.

Minimum price fixes
Fixes #55444

Barter adjustment and caps fixes
Fixes #47569
Fixes #55368
Fixes #46081

Describe the solution

Traders will behave differently, with their own welfare in mind and with the intention of making a profit.

The price penalty for damage is now doubled, so you no longer get a little 30-40% price reduction for an almost destroyed item. It is now 60-80% reduction for almost destroyed items.

Added low cost threshold for npc selling - They will no longer sell stuff to you for free, but for 1c minimum. A trader gotta make a living. They will also refuse to buy items from you that cost 1c or less.

Filthy items will be sold to them at half price.

Barter price adjustment is reworked - they get a trade advantage - which depends on their INT/social and your INT/social. Your selling prices are unaffected, but their stock, they will sell to you at a higher cost, a markup - like real shops do. There is a cap in place - so they can't get too high, and the cap prevents buy/sell prices ever overlapping.

Player sell price adjustment can range from 50% to 140% and NPC price adjustment can range from 160% to 220%.

You can barter them down and your items value up to counteract, but you should not be able to sell them items for more than they sell to you anymore.

Currency items that were getting price adjusted (merch strap for example) leading to money exploits will not be adjusted anymore. You can still trade other faction currency at adjusted rates as normal though.

Describe alternatives you've considered

Considered #57706 for barter solution, but that PR is not conductive to a good barter system at this stage.

I implemented some of their code as it was better and is working with the same code as this PR, but implementing it better. I hope this is okay, I dont know how to add a co-author. Thanks andrei8l

Testing

Filled up on filthy and damaged pants / socks from debug killing some zombies and then tried to trade to an evac center npc to see the changes are working. The pricing and trade refusal are working better.

Additional context

Cheaper damaged items.

Minimum cost of sold items now 1cent

Halved generous pricing reduction for damaged items

andrei8l · 2022-05-13T02:20:53Z

Cleaning filthy items is trivial so why would faction traders refuse them? It would make sense for NPCs with the squeamish trait to refuse them though.

andrei8l · 2022-05-13T02:21:20Z

src/trade_ui.cpp

@@ -69,6 +70,8 @@ std::string trade_preset::get_denial( const item_location &loc ) const
        npc const &np = *_trader.as_npc();
        if( !np.wants_to_buy( *loc, price, market_price ) ) {
            return string_format( _( "%s does not want to buy this" ), np.get_name() );
+        } else if( loc->has_flag( flag_FILTHY ) ) {


Put this in with the rest of the refusal logic in npc::wants_to_buy()

Oh yeah, thats a better spot for it

It loses the "doesnt want filthy items" message, but I guess people will figure that part out

you could change the return value of wants_to_buy() to ret_val<bool> which can store a string for additional context

Now checks in the npc::wants_to_buy() section

stubkan · 2022-05-13T15:19:38Z

Added cost threshold - since you could buy 1000 thread, 500 solder, 500 rags from refugee center for nothing.

Now if an item costs less than 1c it will revert its price to 1c minimum.

Only applies to buying, not selling. Since traders will refuse to buy items that cost less than 5c.

It was a little hard chasing down this bug. It seems the cost calculation was being done in a few different places. Especially for ammo type items such as solder or thread, they were being calculated down to below 1. So I added sanity checks that forced them to revert to 1 if they were calculated lower.

… free

Nebnis · 2022-05-13T17:58:19Z

I would also lower the value of rigid kevlar sheets, they are really easy to get from soldier zombies and sell for an overwhelming 150. You can get like over 15+ from their vests

stubkan · 2022-05-13T18:02:21Z

I would also lower the value of rigid kevlar sheets, they are really easy to get from soldier zombies and sell for an overwhelming 150. You can get like over 15+ from their vests

Oh yeah. Im sure there are other items like that too - But that is a json item level problem so youd need to edit item jsons themselves to balance. This PR is a merchant c++ code PR, it might be better for a separate PR for json item rebalance stuff

stubkan · 2022-05-13T22:06:55Z

Working on fixing another problem with traders - which is #47569

To fix you being able to cheese the barter system by selling objects back for more than you bought them for - npcs have a selling advantage. You can still make deals and adjust the pricing if your INT and social are higher, but it is harder.

Observe the pricing difference with a pocket knife here

This is with both npc and you having default INT/social of 8/0

When my player gets an INT of 12 and social 4 the pricing becomes thus

This is when the NPC has an INT of 12 and social of 4 (and player INT 8, social 0)

Can still change the numbers here... Id like to be able to bring the npc pricing down more

andrei8l · 2022-05-14T22:07:10Z

You're doubling the NPC's prices at no stat/skill difference. 5 points of skill advantage then double it again. That seems a little extreme.

stubkan · 2022-05-14T23:29:56Z

You're doubling the NPC's prices at no stat/skill difference. 5 points of skill advantage then double it again. That seems a little extreme.

Just trying things out. Though, Kevin said that npc buy and sell prices should not be anywhere near the same and I agree - its typical for game trading mechanics to have the prices nowhere near each other and shops irl are the same. Ever try to buy something you sold at the pawn shop back?

I'll have a look at your pr in a while though and play test it out ... Though Id like to combine your PR with mine if its better - because the other changes Im doing here may conflict and cause unpredictable results so Ive been testing it all together

implemented andrei8ls code for; filthy item price reductions (changed to half price) removed redundant visit_items code

Night-Pryanik · 2022-07-03T07:22:16Z

Could you please resolve conflicts?

Fris0uman · 2022-08-04T10:38:14Z

Looks like all the issue that this was supposed to solved have already been solved, also stale

Added check for filthy flag to trade item denial for buying

c454928

Halved generous pricing reduction for damaged items

andrei8l reviewed May 13, 2022

View reviewed changes

Moved filthy flag check from trade_ui.cpp to npc.cpp

55b8341

Now checks in the npc::wants_to_buy() section

github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 13, 2022

Combined both flag checks into one line

7082b0b

github-actions bot removed astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 13, 2022

stubkan added 2 commits May 13, 2022 16:12

Add lower limit for trade sell pricing to 10c

d060a29

Fixed condition to only increase cost if below 10c threshold

d0c9f94

stubkan changed the title ~~Traders won't buy filthy items and pay less for damaged/broken items~~ Traders have trading standards May 13, 2022

Astyle fix

fa0202f

github-actions bot added the astyled astyled PR, label is assigned by github actions label May 13, 2022

stubkan marked this pull request as draft May 13, 2022 16:53

Fixed after pricing adjustment of charge type items below 1 to not be…

d2ba109

… free

Gave npc sellers selling advantage to counteract barter exploit

045f93e

andrei8l mentioned this pull request May 14, 2022

npctrade: rework price adjustment formula #57706

Merged

Moved item freebie price checks to one location

4755683

implemented andrei8ls code for; filthy item price reductions (changed to half price) removed redundant visit_items code

kierandavidmccormick mentioned this pull request Jul 7, 2022

Buying container with content is cheaper than buying only the content #49160

Closed

Fris0uman closed this Aug 4, 2022

Fris0uman added the stale Closed for lack of activity, but still valid. label Aug 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Traders have trading standards #57660

Traders have trading standards #57660

stubkan commented May 13, 2022 •

edited

Loading

andrei8l commented May 13, 2022

andrei8l May 13, 2022

stubkan May 13, 2022

stubkan May 13, 2022

andrei8l May 13, 2022 •

edited

Loading

stubkan commented May 13, 2022 •

edited

Loading

Nebnis commented May 13, 2022

stubkan commented May 13, 2022

stubkan commented May 13, 2022 •

edited

Loading

andrei8l commented May 14, 2022

stubkan commented May 14, 2022

Night-Pryanik commented Jul 3, 2022

Fris0uman commented Aug 4, 2022

Traders have trading standards #57660

Traders have trading standards #57660

Conversation

stubkan commented May 13, 2022 • edited Loading

Summary

Purpose of change

Describe the solution

Describe alternatives you've considered

Testing

Additional context

andrei8l commented May 13, 2022

andrei8l May 13, 2022

Choose a reason for hiding this comment

stubkan May 13, 2022

Choose a reason for hiding this comment

stubkan May 13, 2022

Choose a reason for hiding this comment

andrei8l May 13, 2022 • edited Loading

Choose a reason for hiding this comment

stubkan commented May 13, 2022 • edited Loading

Nebnis commented May 13, 2022

stubkan commented May 13, 2022

stubkan commented May 13, 2022 • edited Loading

andrei8l commented May 14, 2022

stubkan commented May 14, 2022

Night-Pryanik commented Jul 3, 2022

Fris0uman commented Aug 4, 2022

stubkan commented May 13, 2022 •

edited

Loading

andrei8l May 13, 2022 •

edited

Loading

stubkan commented May 13, 2022 •

edited

Loading

stubkan commented May 13, 2022 •

edited

Loading