Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another attunement spell for Magnetism Mage #57508

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

GuardianDll
Copy link
Member

Summary

Mods "new spell for magnetism mage"

Purpose of change

Add new attunement spell for Magnetism Mage

Describe the solution

Spell that deal a small damage, and shut down robots for a while

Describe alternatives you've considered

Not adding this
Add this when EMP effect would be unhardcoded

Testing

Works pretty good

@GuardianDll GuardianDll requested a review from KorGgenT as a code owner May 7, 2022 09:52
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2022

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Send a vawe of high-frequency alternating pulse. It can't hurt really much, but it works great against circuits, shutting them down for a small time. Probably it will work against drones or robots. No, its not EMP

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 7, 2022
@SariusSkelrets
Copy link
Contributor

Targeting a certain flag or species (I don't know how to do it) would probably work better than a hard list to prevent every new robot to update this spell

For example, if I added a new robot (lets say a spiderbot) someone would need to update the spell or else the spiderbot would be immune to the slowdown effect until said update

@GuardianDll
Copy link
Member Author

GuardianDll commented May 7, 2022

If there would have been any way to target the species instead of id i'd be glad to make it
Sadly there is no such, and i dont have enough skills to make one

@KorGgenT KorGgenT merged commit 3b8fd35 into CleverRaven:master Jun 7, 2022
Faalagorn added a commit to Faalagorn/Cataclysm-DDA that referenced this pull request Jun 8, 2022
dseguin pushed a commit that referenced this pull request Jun 9, 2022
bombasticSlacks pushed a commit to bombasticSlacks/Cataclysm-DDA that referenced this pull request Jun 10, 2022
bombasticSlacks pushed a commit to bombasticSlacks/Cataclysm-DDA that referenced this pull request Jun 10, 2022
@GuardianDll GuardianDll deleted the robot_disabler branch August 14, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants