Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few magiclysm fix #57486

Merged
merged 6 commits into from
Jun 10, 2022
Merged

Few magiclysm fix #57486

merged 6 commits into from
Jun 10, 2022

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented May 6, 2022

Summary

Mods "few magiclysm fix"

Purpose of change

Close #53921
Close #54479
Close #56307

Describe the solution

Mana frame got FLOATS flag (yay, magic ships)

Gram's Vorpal strike technique was replaced with new Great Divide technique, with normal probability, but deal only double damage

mon_owlbear_zombie and mon_owlbear_zombie_brute got "starts" 15 and 30 respectively (muliplies with monster evolution scale factor, so by default are [15*4=] 60 and [30*4=] 120 days respectively )

Describe alternatives you've considered

add a mana boat hull

left vorpal strike as it is (0.4% propability with instakill damage)

Testing

Floating disc doesn't sank

Gram deal good damage with okay probability

zowlbears spawns as intended

Additional context

Common vorpal strike damage
image

@GuardianDll GuardianDll requested a review from KorGgenT as a code owner May 6, 2022 19:38
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Melee Melee weapons, tactics, techniques, reach attack Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod astyled astyled PR, label is assigned by github actions labels May 6, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 6, 2022
@KorGgenT KorGgenT merged commit 2497a9d into CleverRaven:master Jun 10, 2022
@GuardianDll GuardianDll deleted the magic_fixes branch August 14, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Melee Melee weapons, tactics, techniques, reach attack Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
2 participants