Upgrading chloromorph and associated trait code to flag checks #57092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t checks to flag checks
|
Will affect mutation.cpp and character.cpp Uncertain if morale.cpp needs updating. Will look at it tomorrow. |
|
Oops. I forgot to update my master with the changes from #55399 first. Closing this PR, updating, then starting over clean. |
github-actions
bot
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Updating code from Makes Chlormorph an explicit upgrade over Roots/Rooter #55399 to use flag checks instead of hardcoded trait id checks.
Describe the solution
A few lines of code
Describe alternatives you've considered
None
Testing
Code upgrade not completed yet.
Additional context
Requested by @I-am-Erk