Pockets that can let item inherit flags #57050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
|
Awesome, thank you! This should allow hand warmers in pockets too, which is a nice QoL for winter. |
github-actions
bot
added
the
BasicBuildPassed
dseguin
added
Items / Item Actions / Item Qualities
github-actions
bot
added
[JSON]
bombasticSlacks
requested review from
Maleclypse,
John-Candlebury and
Mom-Bun
as code owners
github-actions
bot
removed
the
BasicBuildPassed
bombasticSlacks
commented
Apr 27, 2022
github-actions
bot
added
the
BasicBuildPassed
…into inherits-pockets
|
Just an FYI for these, I adjusted the folder and file names for the exosuits and associated files in #57237. |
…into inherits-pockets
Drew4484
pushed a commit
to Drew4484/Cataclysm-DDA
that referenced
this pull request
May 1, 2022
* pocket inherits stuff * adds test module * Update modular_exoskeleton_modules.json * CLANG * Update src/item.cpp
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
additional c++ for #56976
Describe the solution
added ability for pockets to have a "inherits_flags" attribute. Items in the pockets can then have their flags contribute to the above armor. Most useful for items like the exo modules.
Adds a module to test for helmets. Fixes far and near sight as well as adds a zoom function. The idea being that the character always has anything that they are looking at in focus.
Describe alternatives you've considered
Testing
not tested yet
Additional context
@Drew4484