Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Innawoods] Welding and plastic molding #56946

Merged
merged 4 commits into from
Apr 20, 2022
Merged

[Innawoods] Welding and plastic molding #56946

merged 4 commits into from
Apr 20, 2022

Conversation

Sathra225
Copy link
Contributor

Summary

Mods "Makes plastic molding possible, plus welding goggles"

Purpose of change

Plastic molding for bottles and the like needed polycarbonate sheets, which aren't craftable. Removed them from the requirement list. Makeshift vacuum molder and sealer also needed uncraftable parts, fixed that. Also made welding goggles craftable from scratch (with glass goggles).

Describe the solution

Replaced polycarbonate sheet in plastic_molding requirement with plastic chunk. Added leather hoses as alternative to rubber hose in makeshift sealer/vacuum molder. Made vacuum pump + makeshift drivebelt autolearn (belt is needed for vac pump). Added glass goggles to welding goggle recipe as another alternative to the base goggles.

Describe alternatives you've considered

Removing material cost entirely for plastic_molding and updating recipes for increased components.
Figuring out some craftable thermoplastic variant to use instead of polycarbonate. Same with making rubber hoses craftable.

Testing

Made changes, recipes unlocked at correct skill levels. Game didn't crash or throw errors.

Additional context

Items that use the plastic_molding requirement look a bit strange with plastic chunks listed twice, but ultimately harmless. Welding goggles still use plasticworking proficiency even though they don't need any plastic now, but changing that would necessitate adding a new recipe.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mods Issues related to mods or modding Mods: Innawood 🌲 Anything to do with Innawood mod astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 20, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 20, 2022
@dseguin dseguin merged commit a0356ed into CleverRaven:master Apr 20, 2022
@Sathra225 Sathra225 deleted the innawoods-plastic branch April 20, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Innawood 🌲 Anything to do with Innawood mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants