savegame: migrate addiction variants #56915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Saved games with addiction events serialized before #56786 can't be loaded
Fixes: #56916
Describe the solution
Convert the addiction
cata_variant
on save loadDescribe alternatives you've considered
N/A: events are lazily evaluated so the conversion needs to happen during I/O
Testing
#YW5kcmVp.sav
:[ { "add_type": [ "add_type", "PKILLER" ], "character": [ "character_id", "1" ] }, { "count": 1, "first": 16415854, "last": 16415854 } ]
[ { "add_type": [ "addiction_id", "opiate" ], ... ]
count
increased to 2Additional context
Maybe there's a better way; let's see what dseguin or jbytheway have to say