Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap the duration of the forge of wonders' anti-invisibility effect #56900

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Cap the duration of the forge of wonders' anti-invisibility effect #56900

merged 2 commits into from
Apr 18, 2022

Conversation

SariusSkelrets
Copy link
Contributor

@SariusSkelrets SariusSkelrets commented Apr 18, 2022

Summary

Bugfixes "Add a maximal duration to the anti-invisibility effect you get from the forge of wonders"

Purpose of change

Visited the forge a couple of times. 12 weeks after gaining the effect I still can't turn invisible
I assume their security measures shouldn't persist out of their building

Describe the solution

Capping the duration to five minutes

Describe alternatives you've considered

none

Testing

stayed in the forge for a whole day, got out, waited 10 minutes, turned invisible

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 18, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 18, 2022
Copy link
Member

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on potential abuse.

@Maleclypse Maleclypse added the Mechanics: Effects / Skills / Stats Effects / Skills / Stats label Apr 18, 2022
Co-authored-by: Maleclypse <[email protected]>
@github-actions github-actions bot added the <Bugfix> This is a fix for a bug (or closes open issue) label Apr 18, 2022
@dseguin dseguin merged commit 8fa8088 into CleverRaven:master Apr 18, 2022
@SariusSkelrets SariusSkelrets deleted the Cap-Anti-Invisibility-Duration branch April 18, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Effects / Skills / Stats Effects / Skills / Stats Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants